git: Ignore build/lib not lib in gitignore

[themarwhal]

Signed-off-by: Marie Bremner marwhal@fb.com

Summary

We have several non generated directories that are named 'lib' that we don't want to ignore in git.
Instead of blindly ignoring '/lib' and adding exception rules, just ignore 'build/lib' which covers the everything we want. (I think)

From a quick search in my local setup, here are the list of directories with 'lib' (excluding node_modules)

.//lte/gateway/python/build/lib # ok to ignore
.//lte/gateway/c/oai/lib # don't want to ignore
.//lte/gateway/c/oai/code_coverage/lib # already covered by another gitignore
.//feg/radius/lib # don't want ignore
.//build/oai/lib # ok to ignore
.//third_party/build/lib # ok to ignore
# .cache is already covered by another gitignore
.//.cache/go/pkg/mod/cache/download/github.com/facebookincubator/magma/orc8r/lib
.//.cache/go/pkg/mod/cache/download/github.com/lib
.//.cache/go/pkg/mod/github.com/lib
.//orc8r/lib # don't want to ignore
.//orc8r/gateway/python/build/lib # ok to ignore

Test Plan

I built orc8r/agw/nms and checked that my git status looks reasonable

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the DCO check.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks

[rdefosse]

@themarwhal

Thx a lot. I also bothered me a lot when modifying files in lte/gateway/c/oai/lib