fix(mme): Fixed memory leaks observed during network initiated dedicated bearer deactivation procedure #8417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯 A couple initial guidelines
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
Oops! Looks like you failed the Howto
|
ardzoht
changed the title
|
Oops! Looks like you failed the Howto
|
|
@rsarwad can you please add into the Summary the dump of the memory leak? it would help for tracing back exact leak output on the logs, thanks! |
|
Oops! Looks like you failed the Howto
|
1 similar comment
|
Oops! Looks like you failed the Howto
|
feg-workflow 2 files 145 suites 30s ⏱️ Results for commit 89101dc. ♻️ This comment has been updated with latest results. |
ulaskozat
changed the title
|
Oops! Looks like you failed the Howto
|
ulaskozat
changed the title
|
Oops! Looks like you failed the Howto
|
|
@rsarwad could you fix the commit title inline with the PR title as it is a single commit PR, commit title is expected to follow semantic rules as well. |
rsarwad
force-pushed
the
rsarwad_memory_leak_fix_on_dedicated_bearer
branch
from
07462e8
to
a762755
Compare
|
Oops! Looks like you failed the Howto |
…ted bearer deactivation procedure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
rsarwad_memory_leak_fix_on_dedicated_bearer
branch
from
a762755
to
89101dc
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(agw): Fixed memory leaks observed during network initiated dedicated bearer deactivation procedure
Summary
Inconsistently memory leak was observed during execution of test_attach_detach_dedicated_deactivation_timer_expiry.py
Cause for leak is, on first timer timer expiry, mme shall start the timer with some arguments, for which memory would be allocated. So part of start, if timer has valid timer id then first timer is stopped and started again. As part of stop, it returns the memory allocated for timer arguments.
Since timer has expired, timer id will not be found in the timer queue, so timer argument returned from stop was corrupted/incorrect. When start the timer again; it was not starting. Since it was not started, it was resulting into memory leak.
Memory allocated to timer argument would be freed, either on final timer expiry or while stopping using api, esm_ebr_stop_timer()
Below is the back trace where memory leak was observed,
Test Plan
Executed s1ap sanity test suite
Executed test_attach_detach_dedicated_deactivation_timer_expiry.py test case and stopped all services to check memory leaks. This is repeated multiple times.
Signed-off-by: Rashmi rashmi.sarwad@radisys.com