Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/zip cycle pad #88

Merged
merged 3 commits into from May 5, 2014
Merged

Topic/zip cycle pad #88

merged 3 commits into from May 5, 2014

Conversation

steventlamb
Copy link
Contributor

Added utilities to support zipping uneven lists, addresses #84

@steventlamb
Copy link
Contributor Author

modified implementation of -zip for performance, following some of @Fuco1 's suggestions here:
#87

@steventlamb
Copy link
Contributor Author

I'm happy to make that change.

Right now this PR has a mixture of some features and a performance fix. Does it look like these new features will get merged, or should I break the performance fix out into a new PR and close the new feature PR?

@magnars
Copy link
Owner

magnars commented Apr 27, 2014

I like these functions, so I'm happy to merge both in one pull request. :-)

@steventlamb
Copy link
Contributor Author

OK, updated to use (-none? 'null lists)

@magnars
Copy link
Owner

magnars commented Apr 29, 2014

It would be nice to have the changes to -zip be reflected with a few examples. And does it warrant an addendum to the docstring?

@Fuco1: I see that you had some comments on the other thread. Have your concerns been abated?

"Returns an infinite copy of LIST that will cycle through the
elements and repeat from the beginning."
(let ((newlist (-map 'identity list)))
(nconc newlist newlist)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be indented.

@Fuco1
Copy link
Collaborator

Fuco1 commented Apr 29, 2014

I had a dilemma about returning a list vs dotted list, but after I've tried working a bit with dotted lists, they are utterly impossible... so I think lists are better after all.

I guess all issues had been addressed, I've put two more minor comments on the commits, when that is fixed, I guess it's OK to merge.

@magnars
Copy link
Owner

magnars commented Apr 30, 2014

Let me know when you've looked at the last minor issues, @steventlamb :-)

@steventlamb
Copy link
Contributor Author

@magnars You suggested adding examples for n-ary -zip, some were added in this commit that has already been merged: 703bb59
Is that sufficient?

Steve Lamb added 2 commits May 2, 2014 16:51
@steventlamb
Copy link
Contributor Author

@magnars @Fuco1 Updated to drop unused count var and fix indentation.

@magnars
Copy link
Owner

magnars commented May 5, 2014

Thanks :-)

magnars added a commit that referenced this pull request May 5, 2014
@magnars magnars merged commit fb51f8f into magnars:master May 5, 2014
@steventlamb steventlamb deleted the topic/zip_cycle_pad branch May 6, 2014 18:54
@magnars
Copy link
Owner

magnars commented Oct 24, 2014

@steventlamb

Hi Steve!

I'd like to include dash.el into GNU ELPA, but for that we need all
significant contributors to sign some copyright paperwork (same as for
Emacs, to ease up moving code between the two).

You're one of the contributors to dash.el so we'd need you to sign
that paperwork. Would you be willing to do that?

@steventlamb
Copy link
Contributor Author

Gladly. How do we go forward? Are you able to retrieve my email address from the commit logs?

@Fuco1
Copy link
Collaborator

Fuco1 commented Oct 24, 2014

Hi Steve.

Gladly. How do we go forward? Are you able to retrieve my email
address from the commit logs?

See the following instructions I got from Stefan (the Emacs maintainer):

Please email the following information to assign@gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject

line of the message.

REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes? Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Best regards,
Matúš Goljer

@steventlamb
Copy link
Contributor Author

@Fuco1 Thanks, I have sent this info over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants