New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/zip cycle pad #88
Conversation
I'm happy to make that change. Right now this PR has a mixture of some features and a performance fix. Does it look like these new features will get merged, or should I break the performance fix out into a new PR and close the new feature PR? |
I like these functions, so I'm happy to merge both in one pull request. :-) |
OK, updated to use |
It would be nice to have the changes to -zip be reflected with a few examples. And does it warrant an addendum to the docstring? @Fuco1: I see that you had some comments on the other thread. Have your concerns been abated? |
"Returns an infinite copy of LIST that will cycle through the | ||
elements and repeat from the beginning." | ||
(let ((newlist (-map 'identity list))) | ||
(nconc newlist newlist))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be indented.
I had a dilemma about returning a list vs dotted list, but after I've tried working a bit with dotted lists, they are utterly impossible... so I think lists are better after all. I guess all issues had been addressed, I've put two more minor comments on the commits, when that is fixed, I guess it's OK to merge. |
Let me know when you've looked at the last minor issues, @steventlamb :-) |
fixes #84 on github. Add -zip-fill, -cycle and -pad.
Thanks :-) |
Hi Steve! I'd like to include dash.el into GNU ELPA, but for that we need all You're one of the contributors to dash.el so we'd need you to sign |
Gladly. How do we go forward? Are you able to retrieve my email address from the commit logs? |
Hi Steve.
See the following instructions I got from Stefan (the Emacs maintainer): Please email the following information to assign@gnu.org, and we Please use your full legal name (in ASCII characters) as the subject line of the message.REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] [Did you copy any files or text written by someone else in these changes? [Do you have an employer who might have a basis to claim to own [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written Best regards, |
@Fuco1 Thanks, I have sent this info over. |
Added utilities to support zipping uneven lists, addresses #84