-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expansion support for Ensime Mode #181
Conversation
Fantastic! Ping me when its on MELPA and I'll tweet it. |
@fommil You can just subscribe to this ticket, can't you? |
Ah yes that's true. |
@fommil I'll open a PR for Ensime tomorrow, as copyright assignment apparently stand in the way of merging this one. I'm sorry for the hassle, I didn't know this. |
If you contribute to ensime-emacs can you make this an optional dependency? See how we do that for ensime-autacomplete (might be in a PR waiting for merge). Reducing dep list is a high priority right now. |
Sure, that was my plan. It's easy enough 😎 |
@fommil I think it's probably even better to just put this code into a separate package on MELPA, e.g. |
OK, that works too! In a couple of years, we can just fold it into ENSIME proper as all deps will be Emacs core. Make sure you add it to the wiki, we should probably create a "favourite Scala modes" page with stuff like this and some other useful .emacs config. |
@fommil To what wiki? That of Ensime Emacs? If you want I can also use a repo within the Ensime org, for better discoverability of the new extension… |
Yup. I'm actually OK with you dropping it into ensime-emacs and then people need to manually install expand-region if they want to use it. Best that we are consistent with how we handle optional modules. I'm traveling for a day but if you raise a PR I'll show you what needs to be done to make it optional. |
Ok, I'll knock together a PR for Ensime Emacs, and wait for your review. |
Adds support for Ensime Mode, by hooking Ensime's syntactic expansion feature into Expand Region.
/cc @fommil