Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expansion support for Ensime Mode #181

Closed
wants to merge 1 commit into from
Closed

Add expansion support for Ensime Mode #181

wants to merge 1 commit into from

Conversation

swsnr
Copy link

@swsnr swsnr commented Oct 20, 2015

Adds support for Ensime Mode, by hooking Ensime's syntactic expansion feature into Expand Region.

/cc @fommil

@fommil
Copy link

fommil commented Oct 20, 2015

Fantastic! Ping me when its on MELPA and I'll tweet it.

@swsnr
Copy link
Author

swsnr commented Oct 20, 2015

@fommil You can just subscribe to this ticket, can't you?

@fommil
Copy link

fommil commented Oct 20, 2015

Ah yes that's true.

@swsnr swsnr closed this Oct 20, 2015
@swsnr
Copy link
Author

swsnr commented Oct 20, 2015

@fommil I'll open a PR for Ensime tomorrow, as copyright assignment apparently stand in the way of merging this one. I'm sorry for the hassle, I didn't know this.

@fommil
Copy link

fommil commented Oct 20, 2015

If you contribute to ensime-emacs can you make this an optional dependency? See how we do that for ensime-autacomplete (might be in a PR waiting for merge). Reducing dep list is a high priority right now.

@swsnr
Copy link
Author

swsnr commented Oct 20, 2015

Sure, that was my plan. It's easy enough 😎

@swsnr swsnr deleted the scala-mode-expansions branch October 21, 2015 08:54
@swsnr
Copy link
Author

swsnr commented Oct 21, 2015

@fommil I think it's probably even better to just put this code into a separate package on MELPA, e.g. ensime-expand-region or so, to prevent an expand-region dependency from creeping into Ensime right away. What do you think?

@fommil
Copy link

fommil commented Oct 21, 2015

OK, that works too! In a couple of years, we can just fold it into ENSIME proper as all deps will be Emacs core. Make sure you add it to the wiki, we should probably create a "favourite Scala modes" page with stuff like this and some other useful .emacs config.

@swsnr
Copy link
Author

swsnr commented Oct 21, 2015

@fommil To what wiki? That of Ensime Emacs? If you want I can also use a repo within the Ensime org, for better discoverability of the new extension…

@fommil
Copy link

fommil commented Oct 21, 2015

Yup. I'm actually OK with you dropping it into ensime-emacs and then people need to manually install expand-region if they want to use it. Best that we are consistent with how we handle optional modules. I'm traveling for a day but if you raise a PR I'll show you what needs to be done to make it optional.

@swsnr
Copy link
Author

swsnr commented Oct 21, 2015

Ok, I'll knock together a PR for Ensime Emacs, and wait for your review.

@swsnr
Copy link
Author

swsnr commented Oct 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants