Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that tests are not working correctly #231

Closed
wants to merge 1 commit into from

Conversation

neojski
Copy link

@neojski neojski commented Jun 24, 2017

I tried running tests locally and whatever I do they just always pass. I expect this pull request to show a green badge from travis.

@coveralls
Copy link

coveralls commented Jun 24, 2017

Coverage Status

Coverage remained the same at 85.133% when pulling 52f5d16 on neojski:tests-always-pass into 2357f1d on magnars:master.

@neojski
Copy link
Author

neojski commented Jun 24, 2017

Interesting, it passes on my local machine but does fail on travis. I'm wondering if ecukes is broken on 25.2.1.

@neojski
Copy link
Author

neojski commented Jun 24, 2017

It's pretty exciting. If I change:

(Then "^the region should be\\(?: \"\\(.*\\)\"\\|:\\)$"
  "Asserts that the selected region is same as EXPECTED."
  (lambda (expected)
    (let ((actual (espuds-region))
          (message "Expected the region to be '%s', but was '%s'."))
      (cl-assert (equal expected actual) nil message expected actual))))

to

(Then "^the region should be\\(?: \"\\(.*\\)\"\\|:\\)$"
  "Asserts that the selected region is same as EXPECTED."
  (lambda (expected)
    (let ((actual (espuds-region))
          (message "Expected the region to be '%s', but was '%s'."))
      (cl-assert nil nil message expected actual))))

it still passes. If I change it to false, though, it starts to fail.

@neojski
Copy link
Author

neojski commented Jun 24, 2017

In emacs 25.1.1 it works. It looks like this is @ecukes (or, rather espuds) bug.

@neojski
Copy link
Author

neojski commented Jun 24, 2017

It may actually be related to this: ecukes/ecukes#159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants