Merlin #233
Closed
Merlin #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neojski
force-pushed
the
merlin
branch
3 times, most recently
from
4f46a0b
to
9165e30
Compare
neojski
force-pushed
the
merlin
branch
2 times, most recently
from
17fd1b8
to
1ecfbf3
Compare
neojski
force-pushed
the
merlin
branch
2 times, most recently
from
00f7351
to
19552ad
Compare
|
For some reason the xml tests are quite unstable and failing randomly. But merlin tests work well. It's conceivable that we can use ocaml binaries rather instead as described here: http://blog.mlin.net/2013/02/testing-ocaml-projects-on-travis-ci.html (though this blog post looks quite old). @magnars, let me know if you are happy to merge as is. |
neojski
force-pushed
the
merlin
branch
2 times, most recently
from
21e12b4
to
c07b2a2
Compare
neojski
force-pushed
the
merlin
branch
2 times, most recently
from
cc58c53
to
6b86657
Compare
|
I switched travis to use binary ocaml. The tests failed but only for latest emacs and xml and I'm pretty sure it's not caused by this PR. @magnars, I hope you're happy to merge this. |
|
Hey, @magnars, any opinion on this? |
|
Ping @magnars. |
|
This wasn't actually merged, was it? |
|
Ah, I've just noticed that you added a warning that this package is now abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#152 but with working tests (except tests are quite broken with emacs 25.2, see #232).