Skip to content

Commit

Permalink
Use snapshot version of HPI.
Browse files Browse the repository at this point in the history 
The HPI version in use incorrectly sets the metadata for Hudson-Version to null,
which causes the plugin manager to pull in SVN, Maven and CVS as dependencies.

If I want Maven plugin to use token-macro-plugin, then this generates a
nasty circular dependency.

Can be removed when HPI is released and parent pom has been updated.

Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
  • Loading branch information
@magnayn
magnayn committed Mar 6, 2011
1 parent fec2924 commit cfe107d
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions pom.xml
View file
Expand Up @@ -20,6 +20,20 @@
</developer>
</developers>

<build>
<plugins>
<plugin>
<groupId>org.jenkins-ci.tools</groupId>
<artifactId>maven-hpi-plugin</artifactId>
<version>1.65-SNAPSHOT</version>
<extensions>true</extensions>
<configuration>
<showDeprecation>true</showDeprecation>
</configuration>
</plugin>
</plugins>
</build>

<!--
<dependencies>
<dependency>
Expand Down

4 comments on commit cfe107d

@alanharder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you set the parent version above to 1.399 instead of this change?

@magnayn
Copy link
Owner Author

@magnayn magnayn commented on cfe107d Mar 6, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so - the required fix is in hpi plugin 1.65-SNAPSHOT.
Once that is released properly as 1.65, it will need to be added into the plugin master pom. Then it can be set to that and removed.

In the interim, without it there's potential nasty circular dependencies as the metadata gets incorrectly set as
Hudson-Version: null

which jenkins interprets as v < 1.286 ish.

@alanharder
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to the commit with the fix? afaik, Hudson-Version: null was fixed in maven-hpi-plugin 1.64 which is already used by parent/plugin pom 1.399

jenkinsci/maven-hpi-plugin@maven-hpi-plugin-1.63...maven-hpi-plugin-1.64
jenkinsci/maven-hpi-plugin@c3a3a98

@magnayn
Copy link
Owner Author

@magnayn magnayn commented on cfe107d Mar 6, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh; you're right, I tried building against 1.399 and it's fine.

IntelliJ incorrectly pointed me at 255348b, which is the direct ancestor, not the last place it changed.

Can you apply a change to update to 1.399 (it seems peverse to me to issue a pull request ;-) )

Please sign in to comment.