Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Null factions are not cleared after being disbanded, causing dynmap integration to break #100

Open
Cazok opened this issue Mar 28, 2021 · 0 comments

Comments

@Cazok
Copy link

Cazok commented Mar 28, 2021

Affected Plugin

  • Affected Plugin Name: Factions
  • Affected Plugin Version: 3.3.2

Describe your Environment

  • Server Version: git-Paper-"8b47131da" (MC: 1.16.5)

Steps to Reproduce this Bug

  1. Set up or join a server with Factions3 and dynmap integrated
  2. Create a faction
  3. Claim some land
  4. Do /f disband or /f leave
  5. Watch as all factions disappear on the dynmap and console gets spammed with errors

Observed Results

When players disband or leave their faction, but dont unclaim all their land before doing so, the plugin seemingly doesn't clear "null" Factions from the board/map or dynmap (it seems the dynmap pulls data from the board to cause this to happen, although I can't be too sure about that due to how claims are filled in despite being clearly not filled in on the faction board/map). This causes the dynmap integration to break, causing factions to longer show up on the dynmap, and causing tons of errors to get thrown into the console.

Expected Results

I expected players to be able to disband/leave their faction without causing every faction to disappear from the dynmap. Thus, resulting in people having a harder time claiming, figuring out where factions are, and resulting in anyone with console access having to deal with the nightmare of not being able to see anything besides errors in the console, as well as having to go into the factions_board file and painstakingly remove every instance of the disbanded faction's ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant