F npi ndc bugfix #164
Merged
F npi ndc bugfix #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- flows were only calculated for the last out of all policy countries - time period lengths were mapped incorrectly on the data - rewrote scripts for better performance (new scripts are approx 4x faster)
…f_npi_ndc_bugfix
|
can you give me a sign as soon as it is ready for review? |
flohump
approved these changes
Apr 28, 2020
|
@flohump I've made tests already and there is virtually no effect on the results. I expect your test to confirm the same. However, the calculation of the npi/ndc AD policy contains a different type of a bug, i.e. the minimum forest stock constraint is wrongly calculated with respect to what counties actually promise. I'm currently reviewing the policies and changing the code accordingly. The question is: should this merge get reverted or we keep it? It certainly speeds up the calculation, but correction to the AD policy should be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains changes in the start_npi_ndc.R script that were introduced by Jan (correction of flows calculation and time period length; and the improvements for performance), and small fixes for paths corrected by me.
The script is under further development, mainly to revise the calculation for the AD policy, give that the resulting forest lower bounds are inconsistent with AD policy definitions for some regions.