Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed rare infeasibility in peatland "on" realization #328

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Sep 29, 2021

🐦 Purpose of this PR 🐦

  • In some runs I encountered feasibility issues in the peatland "on" module realization
  • These problems are likely caused by small differences in accuracy between variables and parameters in GAMS
  • I introduced two balancing variables with a high cost factor to avoid these infeasibilities

🔧 Checklist for PR creator 🔧

  • Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
  • Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
  • High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg
  • Providing additional information based on PR label
  • Low risk : No new model run needed.
  • Medium risk : Default run based on the current version of the fork from which PR is made
  • High risk
    • Default run from the current develop branch ("_before")
    • Default run based on the current version of the fork from which PR is made ("_after")

Resources_Land_Cover_Cropland-32

Resources_Land_Cover_Pastures_and_Rangelands-15

Costs-2

Emissions_CO2_Land_Land_use_Change-23

Productivity_Landuse_Intensity_Indicator_Tau-28

  • 📉 Performance loss/gain from current default behavior 📈
    • Current develop branch default : 0.5 h
    • This PR's default : 0.48 h

Unknown-61

  • Added changes to CHANGELOG.md
  • Compilation check (model starts without compilation errors - use gams main.gms action=c in model folder for testing).
  • No hard coded numbers and cluster/country/region names.
  • The new code doesn't contain declared but unused parameters or variables.
  • Where relevant, In-code comments added including documentation comments.
  • Made sure that documentation created with goxygen is okay (use goxygen::goxygen() for testing).
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).
  • Self-review of my own code.
  • For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau. %Delete this line in case it is not a high risk run%

⚠️ Additional notes or warnings ⚠️

NA

🚨 Checklist for RSE reviewer 🚨

  • PR is labeled correctly.
  • CHANGELOG is updated correctly
  • No hard coded numbers and cluster/country/region names.
  • No unnecessary increase in module interfaces
  • All required updates in interfaces (if any) have been properly adressed in the module contracts
  • In-code comments and documentation comments are satisfactory.
  • model behavior/performance is satisfactory.
  • Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

  • PR is labeled correctly.
  • CHANGELOG is updated correctly
  • No hard coded numbers and cluster/country/region names.
  • Changes to the model are scientifically sound
  • In-code comments and documentation comments are satisfactory.
  • model behavior/performance is satisfactory.
  • Requested changes (if any) were applied correctly

Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after default config update

@@ -12,6 +12,7 @@ scalars
s58_cost_degrad_onetime One-time costs for peatland degradation (USD05MER per ha) / 0 /
s58_rewetting_switch Peatland rewetting on (Inf) or off (0) / Inf /
s58_fix_peatland Year indicating until when peatland area should be fixed to 2015 levels (year) / 2015 /
s58_cost_balance Artifical cost for balance variable (USD05MER per ha) / 1000000 /
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new scalar introduced here can also be added to default config (as other scalars are also in the default config already from this realization). Other than that, good to go!

Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go 👍🏽

@flohump flohump marked this pull request as ready for review September 29, 2021 12:47
@flohump flohump merged commit e14f88c into magpiemodel:develop Sep 29, 2021
@flohump flohump deleted the f_peatlandBugfix branch June 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants