Disaggregation script from MAgPIE outputs to LUH2-ISIMIP3b

[emolinab]

🐦 Purpose of this PR 🐦

• This pull request seeks to add the output script used to create the disaggregated files requested for LUH harmonization of ISIMIP 3b outputs (an expansion and replacement of disaggregation_LUH2.R).

🔧 Checklist for PR creator 🔧

• Labeling pull request correctly from the label list.

• Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
• Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
• High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg

• Providing additional information based on PR label

• Low risk : No new model run needed.
• Medium risk : Default run based on the current version of the fork from which PR is made
• High risk
  • Default run from the current develop branch
  • Default run based on the current version of the fork from which PR is made

• [NA] 📉 Performance loss/gain from current default behavior 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

• Added changes to CHANGELOG.md

• Compilation check (model starts without compilation errors - use gams main.gms action=c in model folder for testing).

• No hard coded numbers and cluster/country/region names.

• The new code doesn't contain declared but unused parameters or variables.

• Where relevant, In-code comments added including documentation comments.

• [NA] Made sure that documentation created with goxygen is okay (use goxygen::goxygen() for testing).

• [NA] Changes to magpie4 R library for post processing of model output (ideally backward compatible).

• Self-review of my own code.

⚠️ Additional notes or warnings ⚠️

NA

🚨 Checklist for RSE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• No unnecessary increase in module interfaces
• All required updates in interfaces (if any) have been properly adressed in the module contracts
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• Changes to the model are scientifically sound
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

[tscheypidi]

you forgot to label your PR and I was wondering whether the script might fit better in the "projects" category instead of "extra". Besides that green light from my side (did not check the script in detail)

[emolinab]

you forgot to label your PR and I was wondering whether the script might fit better in the "projects" category instead of "extra". Besides that green light from my side (did not check the script in detail)

After further discussion with Florian, we agreed on replacing the current dissagregation_LUH.R file with the script from the PR. which is currently located in extra. Should I still move it to projects?