New employment module and switches for regional factor requirements (for crop and livst) #397

deleip · 2022-05-25T13:31:13Z

🐦 Purpose of this PR 🐦

This PR adds an employment module (36_employment), which calculates agricultural employment (for crop and livestock production) based on total labor costs. Further, switches to use regional factor requirements for crops (for realizations per_ton_fao_may22, sticky_feb18, sticky_labor) and regional factor requirements regression for livestock are included (c38_fac_req and c70_fac_req_regr).

🔧 Checklist for PR creator 🔧

Labeling pull request correctly from the label list.

Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg

Providing additional information based on PR label

Low risk : No new model run needed.
Medium risk : Default run based on the current version of the fork from which PR is made
High risk
- Default run from the current develop branch
- Default run based on the current version of the fork from which PR is made

calibration runs (The default setting cfg$best_calib <- TRUE was used only for the sticky factor costs realization, and cfg$best_calib <- FALSE was used for mixed and per_ton, to avoid cropland levels not matching the validation data. For global factor requirements the calibration values from before are kept, as this corresponds to the old implementation.)
old default vs. new default:
new indicators (ag. employment is calibrated for per_ton_fao with regional factor requirements):

⚠️ Additional notes or warnings ⚠️

NA

🚨 Checklist for RSE reviewer 🚨

PR is labeled correctly.
CHANGELOG is updated correctly
No hard coded numbers and cluster/country/region names.
No unnecessary increase in module interfaces
All required updates in interfaces (if any) have been properly adressed in the module contracts
In-code comments and documentation comments are satisfactory.
model behavior/performance is satisfactory.
Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

PR is labeled correctly.
CHANGELOG is updated correctly
No hard coded numbers and cluster/country/region names.
Changes to the model are scientifically sound
In-code comments and documentation comments are satisfactory.
model behavior/performance is satisfactory.
Requested changes (if any) were applied correctly

…ents

…ment

…code

mishkos

Methodologically all looks great. Smaller comments to address.

mishkos · 2022-06-14T11:05:56Z

modules/36_employment/exo_may22/equations.gms

+
+q36_employment(i2) .. v36_employment(i2)
+                              =e= (vm_cost_prod_crop(i2,"labor") + vm_cost_prod_livst(i2,"labor") + sum(ct,p36_nonmagpie_labor_costs(ct,i2))) *
+                                        (1 / sum(ct,f36_weekly_hours(ct,i2)*s36_weeks_in_year*p36_hourly_costs(ct,i2)));


Since this is doesn't influence the optimization, I'm wondering it should better go to the postsolve instead. Maybe this is a question to @tscheypidi here.

I think we had shortly discussed this a while ago and decided to have it as an equation, as we might make changes in the future for which it then could influence the optimization. But happy to move it to the postsolve if that would be best for now.

modules/36_employment/exo_may22/preloop.gms

modules/36_employment/exo_may22/presolve.gms

modules/38_factor_costs/sticky_feb18/declarations.gms

mishkos

all good.

tscheypidi

some minor comments. Two additional questions:

Did you check that magpie4 and the output scripts are compatible to your renamings in the code?
Your runs (also the default run) show significantly lower runtimes to what is reported in other PRs. Can you explain where this is coming from?

tscheypidi · 2022-06-15T08:20:28Z

config/default.cfg

+# * (sticky_feb18, global fac req)                 "calibration_H12_sticky_feb18_28May22.tgz"
+# * (sticky_feb18, regional fac req)               "calibration_H12_sticky_feb18_reg_13Jun22.tgz"
+# * (sticky_labor, global fac req)                 "calibration_H12_sticky_feb18_28May22.tgz"
+# * (sticky_labor, regional fac req)               "calibration_H12_sticky_feb18_reg_13Jun22.tgz"


this seems to become rather complex, labor intensive having so many different combination of calibration factors. I would think that this is ok for now, but we keep that in mind and think about how we can avoid further extensions of this list or even find solutions for a reduction again.

config/default.cfg

tscheypidi · 2022-06-15T08:30:14Z

modules/36_employment/exo_may22/equations.gms

+
+*' @equations
+
+* excluding labor costs for crop residues (as this is not include in ILO empl. data)


what means "ILO empl."?

employment data from the International labour organization, which is the data source we use. I'll change "empl." to "employment"

modules/36_employment/exo_may22/equations.gms

tscheypidi · 2022-06-15T08:39:51Z

modules/36_employment/module.gms

+
+*' @title Employment
+
+*' @description This module calculates agricultural employment in 


The module description should be a bit more detailed and should be seen as a "module contract" which defines what this module is responsible for and what information it expects in order to fulfill its role.

I should contain the following components: 1) Description of the purpose of the module, 2) statement of what the module will provide back to the model 3) statement of what information it expects from other modules, 4) (if applicable) statement of what is guaranteed to be unaffected by the module (e.g. "no effect on optimization" if this is a general characteristic of the module not just some of its realizations).

The module description is important to define responsibilities and distinguish between responsibilities of the module and the rest model.

If added some more detail. So far, nothing is provided back to the model, and the optimization is not changed. However this is only true in the current implementation and might change with future updates, so I didn't include this as a general statement. Let me know if this is detailed enough now

tscheypidi · 2022-06-15T08:42:03Z

modules/38_factor_costs/per_ton_fao_may22/declarations.gms

@@ -16,6 +16,7 @@ vm_cost_prod_crop(i,req)        Regional factor costs of capital and labor for p
 parameter
 p38_cost_share(t,i,req)       Capital and labor shares of the regional factor costs for plant production   (1)
 p38_share_calibration(i)      Summation factor used to calibrate calculated capital shares with historical values (1)
+i38_fac_req(t_all,i,kcr)      Regional or global factor requirements (USD05MER per tDM)


Suggested change

i38_fac_req(t_all,i,kcr) Regional or global factor requirements (USD05MER per tDM)

i38_fac_req(t_all,i,kcr) Factor requirements (USD05MER per tDM)

I would remove the "regional or global" as the values are always reported on the regional level. The distinction is that in one setup it is assumed that all regional values are identical and the other case it is assumed to have regional differences

tscheypidi · 2022-06-15T08:46:19Z

modules/38_factor_costs/sticky_feb18/declarations.gms

@@ -28,6 +28,8 @@ parameters
 p38_share_calibration(i)              Summation factor used to calibrate calculated capital shares with historical values (1)

 p38_croparea_start(j,w,kcr)           Agricultural land initialization area (mio. ha)
+
+ i38_fac_req(t_all,i,kcr)              Regional or global factor requirements (USD05MER per tDM)


Suggested change

i38_fac_req(t_all,i,kcr) Regional or global factor requirements (USD05MER per tDM)

i38_fac_req(t_all,i,kcr) Factor requirements (USD05MER per tDM)

tscheypidi · 2022-06-15T08:46:51Z

modules/38_factor_costs/sticky_labor/declarations.gms

@@ -34,6 +34,8 @@ parameters

 i38_ces_shr(j,kcr)						Share parameter for CES function (1)
 i38_ces_scale(j,kcr)					Scaling factor for total factor productivity (1)
+
+ i38_fac_req(t_all,i,kcr)               Regional or global factor requirements (USD05MER per tDM)


Suggested change

i38_fac_req(t_all,i,kcr) Regional or global factor requirements (USD05MER per tDM)

i38_fac_req(t_all,i,kcr) Factor requirements (USD05MER per tDM)

deleip · 2022-06-15T09:25:13Z

some minor comments. Two additional questions:

1. Did you check that `magpie4` and the output scripts are compatible to your renamings in the code?

2. Your runs (also the default run) show significantly lower runtimes to what is reported in other PRs. Can you explain where this is coming from?

Yes, I checked magpie4 and the output scripts
I believe it comes from the newer GAMS version.

tscheypidi

looks good

Debbora Leip added 16 commits May 24, 2022 15:41

added switch to use regional crop factor requirements

f06b4c9

added switch to use regional regression for livestock factor requirem…

f695b9f

…ents

corrected file names

e1e27a3

added time dependency for regional crop factor requirements

025f841

bugfixes

4a3aaa4

bugfixes 2

0986a88

added declaration of switches

c576688

bugfixes 3

e33f37b

added employment module

ac5d848

added employment module in default.cfg

33d7f84

bugfix

468b6a2

added employment switch to main.gms

7de7a0c

changed i09_gdp_pc_mer_iso to im_gdp_pc_mer_iso

b5649be

bugfix 2

c3d4e8a

bugfix 3

f29e7a2

bugfix 4

4dbdc99

deleip marked this pull request as draft May 25, 2022 13:31

deleip added Major Substantial modifications High risk Higher risk labels May 25, 2022

deleip changed the base branch from master to develop May 25, 2022 13:39

Debbora Leip added 10 commits May 27, 2022 09:44

added detail on new switches in default.cfg

f16ef84

removed unused parameter

b0f99e4

merge develop into PR

40ef981

updated input data

2248059

updated calibration script for factor cost realizations

dd68535

bugfix

0e6e101

removed old code

7a14e13

bugfix2

15add6a

updated descriptions and comments

bf9587f

updated comments

5f08659

Debbora Leip added 11 commits June 8, 2022 22:33

updated comments 2

77d99f9

Merge branch 'develop' of github.com:magpiemodel/magpie into f_employ…

0753f96

…ment

updated changelog

1663d7f

update

357d9b4

updated calibration runs

1950033

updated calibration

0786cbd

fixed description of s39_ignore_calib in default.cfg

0561a28

moved calibration of livstock regression from pre-processing to GAMS …

e35e661

…code

bugfix filenames

0ce6e87

another bugfix

b8080fb

updated calibration tgz, again

e6bb2c0

deleip requested review from tscheypidi and mishkos June 13, 2022 20:53

deleip changed the title ~~[draft] New employment module and switches for regional factor requirements (for crop and livst)~~ New employment module and switches for regional factor requirements (for crop and livst) Jun 13, 2022

deleip marked this pull request as ready for review June 13, 2022 20:54

mishkos reviewed Jun 14, 2022

View reviewed changes

addressed comments

032368a

mishkos approved these changes Jun 15, 2022

View reviewed changes

tscheypidi requested changes Jun 15, 2022

View reviewed changes

addressed comments

4f1c338

tscheypidi approved these changes Jun 15, 2022

View reviewed changes

addressed comments

84ec9d6

deleip merged commit c146e0a into magpiemodel:develop Jun 15, 2022

deleip deleted the f_employment branch November 2, 2023 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New employment module and switches for regional factor requirements (for crop and livst) #397

New employment module and switches for regional factor requirements (for crop and livst) #397

deleip commented May 25, 2022 •

edited by tscheypidi

Loading

mishkos left a comment

mishkos Jun 14, 2022

deleip Jun 14, 2022

mishkos left a comment

tscheypidi left a comment

tscheypidi Jun 15, 2022

tscheypidi Jun 15, 2022

deleip Jun 15, 2022

tscheypidi Jun 15, 2022

deleip Jun 15, 2022

tscheypidi Jun 15, 2022

tscheypidi Jun 15, 2022

tscheypidi Jun 15, 2022

deleip commented Jun 15, 2022

tscheypidi left a comment


		*' @equations

		* excluding labor costs for crop residues (as this is not include in ILO empl. data)


		*' @title Employment

		*' @description This module calculates agricultural employment in

	i38_fac_req(t_all,i,kcr) Regional or global factor requirements (USD05MER per tDM)
	i38_fac_req(t_all,i,kcr) Factor requirements (USD05MER per tDM)

New employment module and switches for regional factor requirements (for crop and livst) #397

New employment module and switches for regional factor requirements (for crop and livst) #397

Conversation

deleip commented May 25, 2022 • edited by tscheypidi Loading

🐦 Purpose of this PR 🐦

🔧 Checklist for PR creator 🔧

⚠️ Additional notes or warnings ⚠️

🚨 Checklist for RSE reviewer 🚨

🚨 Checklist for MAgPIE reviewer 🚨

mishkos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mishkos left a comment

Choose a reason for hiding this comment

tscheypidi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deleip commented Jun 15, 2022

tscheypidi left a comment

Choose a reason for hiding this comment

deleip commented May 25, 2022 •

edited by tscheypidi

Loading