-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSEC modeling script for global runs #426
FSEC modeling script for global runs #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my side. Does the change in Tau require a test run of the develop branch?
I have done a default run test now (see updated text above) |
@@ -16,7 +16,7 @@ else | |||
vm_tau.lo(h, tautype) = pcm_tau(h, tautype); | |||
); | |||
|
|||
vm_tau.up(h,tautype) = 2*pcm_tau(h,tautype); | |||
vm_tau.up(h,tautype) = 3 * pcm_tau(h,tautype); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is odd that this is being required to find feasible solutions. This is really far off a realistic solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only required when we use the combination of the new pasture realization (gms$past <- "grasslands_apr22", gms$c31_past_suit_scen <- "ssp245") and a very strict land conservation and restoration scenario (cfg$gms$c22_protect_scenario <- "HalfEarth").
Maybe @mppalves @alexkoberle or @bodirsky want to add to the discussion, so that we can decide whether this change is justified for this PR or whether we need to refrain from using this combination right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new realization differentiates managed pastures and rangelands. Tau does not apply to rangelands.
There is a strong decline of yields because of climate change impacts that leads to a high need to intensify or expand the small pasture areas. Given the strict Half Earth protection scenario, this is difficult and requires huge investments that require relaxing the upper limit for tau here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be cfg$magicc_emis_scen <- NULL
not "NULL"
. Otherwise the PR looks ok now for me. I still don't understand why the higher upper limit for tau might be needed but also don't see a good alternative for it if you say that some runs get infeasible otherwise.
🐦 Purpose of this PR 🐦
🔧 Checklist for PR creator 🔧
Did not change results of default.
CHANGELOG.md
gams main.gms action=c
in model folder for testing).goxygen
is okay (usegoxygen::goxygen()
for testing).magpie4
R library for post processing of model output (ideally backward compatible).🚨 Checklist for RSE reviewer 🚨
CHANGELOG
is updated correctly🚨 Checklist for MAgPIE reviewer 🚨
CHANGELOG
is updated correctly