Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creation of FSDP_process & revision of FSDP_collect #450
Creation of FSDP_process & revision of FSDP_collect #450
Changes from 15 commits
bc7e502
596fe84
c9843cb
e5f2328
5311d32
bc69f98
6e55841
05bfa80
3a9834b
6c90630
388809f
c010e3a
57eb672
cb630ac
b1fa0ce
3e4b005
0c54fde
282f62c
6f399f5
87ecf03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in principle, i recommend using our write.magpie and write.report functions as they have a more standardized format. but now, i would keep it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficulty is that I need to run csv2gdx on it, so the .mif format would have been clunkier. Unless write.report can do more than .mifs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be an option to use
writeGDX
if the aim is to write the data to a gdx file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slept on this suggestion, and I think that - although it would greatly improve this entire workflow - I'm going to say that for now I would prefer to leave the code as-is. To do this properly, I would need to re-write the magpie4 function in addition to this function. When we port this code to future projects, I'll do the work of revising it properly. For now we have a working solution. I feel quite silly for not using this in the first place. I guess way back then I wanted to use .csvs because I thought it would be simpler for me and then got locked-in.
This file was deleted.
This file was deleted.