Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃惁 Purpose of this PR 馃惁
The last Dockerfile update was two years ago. In the past two years, MAgPIE has undergone numerous updates and its reliance on the environment has also changed. This old version of the Dockerfile is currently unusable (can't successfully run MAgPIE after building and running the docker image).
Docker is the easiest way to run MAgPIE on a new machine. At the same time, it also enables the beginners of the MAgPIE to avoid the trouble of cumbersome environment configuration, and can concentrate on the learning and setting of the model itself.
I made an update to the Dockerfile. I have tested it to be able to run the default configuration and generate the validation.pdf successfully.
The updated details are as follows:
proj
,gdal
,git
and some libs to theapt-get install
list.ncdf4
,raster
, etc.The version of GAMS can be easily changed by editing
LATEST
andLATEST_SHORT
in the Dockerfile.As stated in README.md:
Note, as of September 2022, the latest GAMS version is 40.3, but this version has not been tested. It has been tested that MAgPIE works fine with GAMS 40.2.
@tscheypidi @giannou @pfuehrlich-pik
馃敡 Checklist for PR creator 馃敡
馃搲 Performance loss/gain from current default behavior 馃搱
Added changes to
CHANGELOG.md
CHANGELOG.md
is better done by the MAgPIE team.**main** Update Dockerfile for running MAgPIE in a container
Compilation check (model starts without compilation errors - use
gams main.gms action=c
in model folder for testing).No hard coded numbers and cluster/country/region names.
The new code doesn't contain declared but unused parameters or variables.
Where relevant, In-code comments added including documentation comments.
Made sure that documentation created with
goxygen
is okay (usegoxygen::goxygen()
for testing).Changes to
magpie4
R library for post processing of model output (ideally backward compatible).Self-review of my own code.
In case of updated cellular input tgz file in default.cfg: scenario_config.csv has been updated accordingly (rcp1p9, rcp2p6 etc)
NA
馃毃 Checklist for RSE reviewer 馃毃
CHANGELOG
is updated correctly馃毃 Checklist for MAgPIE reviewer 馃毃
CHANGELOG
is updated correctly