Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean the REMIND coupling interface #476

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

dklein-pik
Copy link
Member

🐦 Description of this PR 🐦

Clean the REMIND coupling interface (remove deletePlus, clean code)

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

  • Self-review own code

  • Document changes

  • Perform test runs

📉 Performance changes 📈

  • Current develop branch default : ** mins
  • This PR's default : ** mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate

@dklein-pik dklein-pik merged commit dfb6b7e into magpiemodel:develop Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low risk Low risk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants