Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSDP output script update #479

Merged
merged 3 commits into from
Nov 21, 2022
Merged

FSDP output script update #479

merged 3 commits into from
Nov 21, 2022

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Nov 18, 2022

馃惁 Description of this PR 馃惁

馃敡 Checklist for PR creator 馃敡

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via gams main.gms action=c
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Default run based on the current version of the fork from which PR is made
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

馃搲 Performance changes 馃搱

  • Current develop branch default : ** mins
  • This PR's default : ** mins

馃毃 Checklist for reviewer 馃毃

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate

@flohump flohump added Minor Smaller modifications Low risk Low risk labels Nov 18, 2022
@flohump flohump marked this pull request as ready for review November 18, 2022 14:44
Copy link
Member

@FelicitasBeier FelicitasBeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

scripts/output/projects/FSDP_collect.R Outdated Show resolved Hide resolved
flohump and others added 2 commits November 21, 2022 10:57
Co-authored-by: Pascal F眉hrlich <82826417+pfuehrlich-pik@users.noreply.github.com>
@flohump flohump merged commit eb543a3 into magpiemodel:develop Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low risk Low risk Minor Smaller modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants