Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General docu improvements #585

Merged
merged 3 commits into from
Feb 5, 2023
Merged

General docu improvements #585

merged 3 commits into from
Feb 5, 2023

Conversation

OrtnerMichael
Copy link
Member

just fixing minor bugs

@OrtnerMichael
Copy link
Member Author

@Alexboiboi any idea ? at home everything is pass and pyling is 10/10

@Alexboiboi
Copy link
Member

Alexboiboi commented Feb 3, 2023

Tests are failing on CI, because of a new version of pylint which came out very recently. I already mentioned this in #584 and fixed the linting issues there. If we merge #584 first and then pull from main into your PR branch, it should be fine

@codecov-commenter
Copy link

Codecov Report

Merging #585 (a4f7892) into main (3f35c75) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          52       52           
  Lines        5658     5658           
=======================================
  Hits         5646     5646           
  Misses         12       12           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Alexboiboi
Copy link
Member

Since some time the tests are randomly failing on matplotlib plotting. Rerunning the failed test solves the problem but this is a bit annoying

@Alexboiboi Alexboiboi merged commit 74a8a4d into main Feb 5, 2023
@Alexboiboi Alexboiboi deleted the general_docu_improvements branch February 5, 2023 13:49
Alexboiboi added a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants