Defer Style initialization to when it is needed #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OrtnerMichael Please merge this, reviewing should only take a couple of minutes! Thx |
OrtnerMichael
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
When working on some routine code where the creation of magpylib objects is very frequent, specifying style attributes cost some significant additional initialization time, so we tend to avoid using them in these cases. However it is quite convenient to be able to give at least a
style.labelto our objects in order to track them more easily later.This PR partly addresses this issue by deferring the style class tree initialization to when it is really called explicitly (e.g.
obj.style...). It allows to declare somestyle_kwargsat init level without carrying the time penalty right away. This would be even more relevant if we decide to implement #397.Here some before/after examples to illustrate the use cases: