Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show disconnected trimesh #618

Merged
merged 4 commits into from
Jun 23, 2023
Merged

fix show disconnected trimesh #618

merged 4 commits into from
Jun 23, 2023

Conversation

Alexboiboi
Copy link
Member

fixes displaying disconnected meshes with plotly. Only discovered in the docs

@Alexboiboi Alexboiboi self-assigned this Jun 23, 2023
@Alexboiboi Alexboiboi added this to the 4.3 milestone Jun 23, 2023
@Alexboiboi Alexboiboi marked this pull request as draft June 23, 2023 09:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #618 (343cdb5) into main (35ed903) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #618   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          54       54           
  Lines        6317     6321    +4     
=======================================
+ Hits         6305     6309    +4     
  Misses         12       12           
Impacted Files Coverage Δ
magpylib/_src/display/traces_generic.py 100.00% <100.00%> (ø)
magpylib/_src/display/traces_utility.py 100.00% <100.00%> (ø)

try: # for mesh3, use only vertices part of faces for range calculation
inds = np.array([t[k] for k in "ijk"], dtype="int64").T
pts = pts[inds].reshape(-1, 3)
except KeyError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
Copy link
Member

@OrtnerMichael OrtnerMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alles klar

@Alexboiboi Alexboiboi marked this pull request as ready for review June 23, 2023 17:18
@Alexboiboi Alexboiboi merged commit db82c1c into main Jun 23, 2023
11 checks passed
@Alexboiboi Alexboiboi deleted the fix-show-disconnected-mesh branch June 23, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants