Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks for python 3.8+ #624

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

Alexboiboi
Copy link
Member

update hooks:

  • reorder-python-imports
  • pyupgrade

@OrtnerMichael, don't squash, just merge please

Boisselet Alexandre (IFAT DC ATV SC D TE2) added 2 commits June 26, 2023 09:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #624 (51efff3) into main (b145c08) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          54       54           
  Lines        6389     6389           
=======================================
  Hits         6372     6372           
  Misses         17       17           

@OrtnerMichael
Copy link
Member

test got stuck - rerunning test

@Alexboiboi
Copy link
Member Author

test got stuck - rerunning test

did you retrigger anything? On the azure-pipepline site it shows that all tests are through but it does not forward the message to github apparently.
I created an empty commit to retrigger the CI. We will see then if it works.

Maybe it is the time to switch to github workflows for the CI. Also I don't really get why codeQL is taking ages to finish

@Alexboiboi
Copy link
Member Author

@OrtnerMichael now ready

Copy link
Member

@OrtnerMichael OrtnerMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the power invested in me I graciously accept this pr. may thy code run well

@OrtnerMichael OrtnerMichael merged commit a4c95d2 into main Jun 28, 2023
10 checks passed
@OrtnerMichael OrtnerMichael deleted the udpate-pre-commit-hooks branch June 28, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants