Relax positional tolerance to reduce error occurrences in CylinderSegment special cases
#651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower tolerance leads to less errors in the special case treatment
Codecov Report
@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 55 55
Lines 7000 7000
=======================================
Hits 6944 6944
Misses 56 56
|
Alexboiboi
changed the title
CylinderSegment special cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower tolerance leads to less errors in the special case treatment