Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matplotlib magnetization colors display for valid magnetization #653

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Alexboiboi
Copy link
Member

magnetization criteria fixed (bad parenthesis)

@Alexboiboi Alexboiboi added this to the 4.4 milestone Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #653 (43a51eb) into main (1016229) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   99.20%   99.22%   +0.02%     
==========================================
  Files          55       55              
  Lines        7000     7000              
==========================================
+ Hits         6944     6946       +2     
+ Misses         56       54       -2     
Files Changed Coverage Δ
magpylib/_src/display/traces_generic.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@OrtnerMichael OrtnerMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@Alexboiboi Alexboiboi merged commit 18ae9fd into main Aug 11, 2023
12 checks passed
@Alexboiboi Alexboiboi deleted the fix_mpl_mag_slicing branch August 11, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

good objects show badly
2 participants