Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address CodeQL report #688

Merged
merged 51 commits into from
Dec 9, 2023
Merged

Address CodeQL report #688

merged 51 commits into from
Dec 9, 2023

Conversation

Alexboiboi
Copy link
Member

@Alexboiboi Alexboiboi commented Dec 1, 2023 •
edited

This PR aims to address all code quality checks errors and warnings. I also adds linting to the test files with pylint. Some test also got some refactoring using the pytest.parametrize feature where it makes sense ( e.g. input checks).

Boisselet Alexandre (IFAT DC ATV SC D TE2) added 2 commits December 1, 2023 13:35
@Alexboiboi Alexboiboi added refactoring CI/CD Continuous Integration / Continuous Delivery labels Dec 4, 2023
Boisselet Alexandre (IFAT DC ATV SC D TE2) added 4 commits December 4, 2023 15:31
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2023
View reviewed changes
magpylib/_src/display/traces_generic.py Dismissed Show dismissed Hide dismissed
magpylib/_src/display/traces_utility.py Dismissed Show dismissed Hide dismissed
Boisselet Alexandre (IFAT DC ATV SC D TE2) added 3 commits December 4, 2023 16:37
Boisselet Alexandre (IFAT DC ATV SC D TE2) added 3 commits December 4, 2023 17:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2023
View reviewed changes
tests/test_obj_Collection.py Fixed Show fixed Hide fixed
tests/test_obj_Collection.py Fixed Show fixed Hide fixed
magpylib/_src/defaults/defaults_utility.py Fixed Show fixed Hide fixed
magpylib/_src/defaults/defaults_utility.py Dismissed Show dismissed Hide dismissed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2023
View reviewed changes
magpylib/_src/defaults/defaults_utility.py Dismissed Show dismissed Hide dismissed
@Alexboiboi Alexboiboi marked this pull request as ready for review December 6, 2023 15:00
@Alexboiboi Alexboiboi added this to the 4.5 milestone Dec 7, 2023
OrtnerMichael
OrtnerMichael approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@OrtnerMichael OrtnerMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I approve, but I don't merge.

As I wrote on signal - if I misunderstood, if you think its fine, or from no on its only draft prs .... then please merge at will!

@Alexboiboi Alexboiboi merged commit 22edbcc into main Dec 9, 2023
22 checks passed
@Alexboiboi Alexboiboi deleted the fix/code-ql branch December 11, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrtnerMichael OrtnerMichael OrtnerMichael approved these changes

Assignees
No one assigned
Labels
CI/CD Continuous Integration / Continuous Delivery refactoring
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alexboiboi @OrtnerMichael