-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Guava's Sets.UnmodifiableNavigableSet #54
Conversation
try { | ||
Class<?> clazz = Class.forName(Sets.class.getCanonicalName() + "$UnmodifiableNavigableSet"); | ||
Field field = clazz.getDeclaredField("delegate"); | ||
field.setAccessible(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field should be resolved and cached at construction time so that it's not done per write.
Thanks for the PR! Can you please squash the commits to a single one? |
Thanks for the PR! How urgent is a release for you? |
Not urgent, we had a less robust serializer in place before that we can use until a release is made here. |
Ok |
I just released 0.39 with this change. I also did another release 0.40, with kryo updated to 4.0.0. |
Adds support for Guava's Sets.UnmodifiableNavigableSet