-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add serializers for mutable Guava multimaps #57
Conversation
private static final boolean IMMUTABLE = false; | ||
|
||
public ArrayListMultimapSerializer() { | ||
super(DOES_NOT_ACCEPT_NULL, IMMUTABLE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm copying the existing classes here but I'm confused: in ImmutableMapSerializer
, etc., this DOES_NOT_ACCEPT_NULL
is passed for Serializer
's constructor's acceptsNull
argument, which seems a bit backward? The names and values may need flipping, but the integration tests pass. 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked it, is this null case even tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My tests do try serializing null values.
Thanks for the PR! I'm currently/still on vacation, will have a deeper look at it when I'm back (in 2 weeks). Early feedback:
|
I think the separate base classes do a lot for reuse and decluttering, though could probably move each with default visibility into the actual file of one of their concrete extensions if that would be preferable. No hurry on my part, enjoy your vacation and good luck with catchup afterward. 😃 |
Thanks for the PR, I just released it with 0.39. |
Btw, I also just updated the kryo dependency to 4.0.0 and released kryo-serializers 0.40 with this. |
Provides serializers and accompanying tests for various Google Guava multimaps.
Does not attempt
Kryo.copy
support nor serialization ofTreeMultimap
s' comparators.