UnicodeBlockSerializer #70
Conversation
New serializer for Character.UnicodeBlock, with test. Takes into account that this class is effectively an enum.
Remove use of diamond operator, to restore JDK6 compatibility
|
@Pr0methean Thanks for the contribution. Perhaps next time you could do this work on a local branch, and once everything is working, squash, push, and pull request. The email spam for every one of these commits for all 31 watchers of this repository isn't very polite, thanks! 😉 |
getFields() isn't working
2 similar comments
|
@3xp0n3nt Will do. Sorry, I didn't see your comment until after I'd finished, and I didn't realize I'd left the PR open after the tests had failed. |
|
@Pr0methean No problem. 😺 |
|
@Pr0methean thanks for the PR! I don't see any reason why this shouldn't go directly into kryo, as it's part of the jdk and not jvm/vendor specific. Can you please submit the PR against kryo? |
| try { | ||
| assertSame(deserialize(kryo, serialized, UnicodeBlock.class), | ||
| UnicodeBlock.UNIFIED_CANADIAN_ABORIGINAL_SYLLABICS); | ||
| } catch (NullPointerException e) { |
There was a problem hiding this comment.
|
The update to the README is https://github.com/magro/kryo-serializers/pull/70/files#diff-0a369498a5a8db3ac8fa606b544c9810. The debug code is removed from the test in https://github.com/magro/kryo-serializers/pull/70/files#diff-328d875a27bcefdefd6a0d692c6b7d66 |
|
Thanks! |
New serializer for Character.UnicodeBlock, with test. Takes into account
that this class is effectively an enum.