Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary rejected by Apple #155

Open
ssmlee04 opened this issue Sep 7, 2016 · 13 comments
Open

Binary rejected by Apple #155

ssmlee04 opened this issue Sep 7, 2016 · 13 comments

Comments

@ssmlee04
Copy link

ssmlee04 commented Sep 7, 2016

From Apple
Performance - 2.5.1

Your app uses or references the following non-public APIs:

: setResult: 

The use of non-public APIs is not permitted on the App Store because it can lead to a poor user experience should these APIs change.

I search the term setResult and I think this belongs to the Facebook login package that I was using

xxxx$ grep -Rnis 'setResult:' *
Binary file ios/FBSDKCoreKit.framework/FBSDKCoreKit matches
Binary file node_modules/react-native-facebook-login/FacebookSDK/FBSDKCoreKit.framework/FBSDKCoreKit matches

I am using react-native-facebook-login v1.3.0. And my RN is 0.31.0. Thanks.

@zeeshansshaikh
Copy link

i got the same issue
did you find the solution ?

@ssmlee04
Copy link
Author

ssmlee04 commented Sep 9, 2016

no not yet. I am also waiting for updates. :p

@choimyungji
Copy link

i got the same issue too.

@lwhiteley
Copy link
Contributor

Maybe the lib needs to be updated

On Sat, Sep 10, 2016, 9:37 PM choimyungji notifications@github.com wrote:

i got the same issue too.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#155 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF02eVjgm_T2pTyqEz0NOGDIKeYB8_9bks5qo1tTgaJpZM4J2rsO
.


Regards
Layton Whiteley

@choimyungji
Copy link

the symbol 'setResult' that facebooksdk has loaded in my binary.
so i tried remove link option '-all_loads' and i see no 'setResult' symbol my binary
i'll register this binary to app store

thanks.

@choimyungji
Copy link

i removed -all_load option and i found no setResult on 'nm' command but found on 'strings' command.
i'll check more again. sorry

@ssmlee04
Copy link
Author

Are you doing something with objective C when you say you removed -all_load option?

@robertkeizer
Copy link

Just to chime in, my company has hit the same rejection.

@AxiomxCell
Copy link

Our app version update got rejected with the same issue. Facebook has to update the library ASAP.

@choimyungji
Copy link

Ah.. I'm waiting review on my app...

@mvoong
Copy link

mvoong commented Sep 13, 2016

We also had the same issue yesterday. As it's a very generic name, let's all please appeal to get them to remove the symbol name from their blacklist. We also got rejected for the symbol "displayName", which in my opinion is also very generic.

@ssmlee04
Copy link
Author

ssmlee04 commented Sep 14, 2016

I submitted a new version a few days ago. As stupid as this may sound it passed checking this time even though my app still uses the Facebook SDK. I guess we should just keep submitting new builds and at the same time appeal for them to change.

@mvoong
Copy link

mvoong commented Sep 14, 2016

Our app just got approved after appealing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants