Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View.propTypes has been removed in 0.49 #279

Closed
dseipp opened this issue Oct 22, 2017 · 8 comments
Closed

View.propTypes has been removed in 0.49 #279

dseipp opened this issue Oct 22, 2017 · 8 comments

Comments

@dseipp
Copy link

dseipp commented Oct 22, 2017

Unable to run in release mode as my app crashes with undefined is not an object (evaluating 'l.View.propTypes.style').

react: 16.0.0
react-native: 0.49.4
prop-types: 15.6.0
react-native-facebook-login: 1.6.0

@GH974
Copy link

GH974 commented Oct 28, 2017

Hi, try this solution temporaly,

in project_name/node_modules/react-native-facebook-login/index.ios.js

add in top import react-native this ViewPropTypes

an exemple after edited
import { View, ViewPropTypes, StyleSheet, NativeModules, NativeMethodsMixin, DeviceEventEmitter, requireNativeComponent } from 'react-native';

and bottom file replace in FBLogin.propTypes ={ style : View.propTypes.style} per ViewPropTypes.style

An exemple after replace

FBLogin.propTypes = { style: ViewPropTypes.style, permissions: PropTypes.array, // default: ["public_profile", "email"] loginBehavior: PropTypes.number, // default: Native onLogin: PropTypes.func, onLogout: PropTypes.func, onLoginFound: PropTypes.func, onLoginNotFound: PropTypes.func, onError: PropTypes.func, onCancel: PropTypes.func, onPermissionsMissing: PropTypes.func, };

It's work for me...

@rmn528
Copy link

rmn528 commented Nov 2, 2017

when this change is gonna be part from the repo?

@dseipp
Copy link
Author

dseipp commented Nov 2, 2017

@GH974 , appreciate the suggestion. Unfortunately changing the node module directly only works locally. The CI build won't pick it up.

@holden-caulfield
Copy link

Why is the PR referenced above not merged already?

This just exploded on my face yesterday when I tried to release a new app for the first time... is particularly nasty because it works just fine on development. And also very hard to hunt down the root cause, just wasted a day of work.

A very simple, straightforward fix for such a blocking issue should got its way into master quite faster

@aramkarapetian
Copy link

hi guys, we also end up debugging for four hours. How can we help to speed up the merge? Otherwise we will end up forking and other nasty workarounds. Please merge.

@JanErikFoss
Copy link

Please merge

@meodemsao
Copy link

please merge

@magus
Copy link
Owner

magus commented Mar 13, 2018

Thanks for reporting this, the fix is out in version 1.6.1!

@magus magus closed this as completed Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants