-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for removed View.propTypes #286
Conversation
Please merge this... so far the library can't be use on a production release that uses the latest RN because of this bug |
Could you merge this already? The whole library is unusable because this simple fix isn't merged. |
I've wasted hours looking for the problem. Please fix this. To solve local, i edit the node_module. |
Sweet Jesus. Push the button |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementing these changes would assure the library remains compatible with older versions of React Native.
This could ensure fast approval?
index.ios.js
Outdated
@@ -90,7 +91,7 @@ class FBLogin extends Component { | |||
} | |||
|
|||
FBLogin.propTypes = { | |||
style: View.propTypes.style, | |||
style: ViewPropTypes.style, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest to use a ternary here to keep the library backwards compatible (< RN 0.49)?
Like this:
const viewPropTypes = ViewPropTypes || View.propTypes
FBLogin.propTypes = {
[...],
style: viewPropTypes.style,
[...],
}
@YusukeShibata it seems you also forgot to update their example component at |
Please merge!! |
+1 |
Thanks @habovh , I pushed new commits. |
Please make it finally available in the master branch. |
@Dalamar If you're in a hurry you can still use @YusukeShibata's fork from GitHub instead of the official npm package until it gets merged. |
Thanks for reporting this, the fix is out in version 1.6.1! |
Fixed the issue: #279