-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression ComboBox style in BTRFS Properties shall be set to CBS_DROPDOWNLIST (shall not be editable) #255
Comments
@maharmstone : What's your view on this ? |
Why not simply do that? |
Because I saw "no open PR"... but yes, you're right, i'll do it tomorrow for sure ! |
PR created : #258 |
Any schedule for reviewing / integrating the above mentionned PR ? Thanks ! |
Any roadmap for review and integration of this PR ? |
It'll be done some time before the next release. I appreciate you sending a patch, but I've been busy with other things, and cosmetic changes are always going to be low priority. |
OK, very clear. |
I can confirm that this issue has been fixed in 1.7.3. |
@ElpizoZ, you have been told in both your previous incarnations not to spam the comments. If I ever decide that I need you to mind them for me, I'll be in touch. |
So, I can't let you know that an issue is no longer occurring? |
Compression ComboBox style in BTRFS Properties shall be set to CBS_DROPDOWNLIST (shall not be editable)
See PR in reactOS : reactos/reactos#2677 and associated Jira ticket : https://jira.reactos.org/browse/CORE-16971
Would you accept to do the change "upstream" in BTRFS ?
In shellbtrfs/shellbtrfs.rc
COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP
to be changed in
COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP
I can provide a pull request for that if needed.
The text was updated successfully, but these errors were encountered: