Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression ComboBox style in BTRFS Properties shall be set to CBS_DROPDOWNLIST (shall not be editable) #255

Closed
ghost opened this issue Apr 27, 2020 · 11 comments

Comments

@ghost
Copy link

ghost commented Apr 27, 2020

Compression ComboBox style in BTRFS Properties shall be set to CBS_DROPDOWNLIST (shall not be editable)

See PR in reactOS : reactos/reactos#2677 and associated Jira ticket : https://jira.reactos.org/browse/CORE-16971

Would you accept to do the change "upstream" in BTRFS ?

In shellbtrfs/shellbtrfs.rc
COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP
to be changed in
COMBOBOX IDC_COMPRESS_TYPE,63,245,48,13,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP

I can provide a pull request for that if needed.

@ghost
Copy link
Author

ghost commented Apr 27, 2020

@maharmstone : What's your view on this ?

@SergeGautherie
Copy link
Contributor

I can provide a pull request

Why not simply do that?

@ghost
Copy link
Author

ghost commented Apr 27, 2020

Because I saw "no open PR"... but yes, you're right, i'll do it tomorrow for sure !

@ghost
Copy link
Author

ghost commented Apr 28, 2020

PR created : #258

@ghost
Copy link
Author

ghost commented May 7, 2020

Any schedule for reviewing / integrating the above mentionned PR ? Thanks !

@ghost
Copy link
Author

ghost commented May 14, 2020

Any roadmap for review and integration of this PR ?

@maharmstone
Copy link
Owner

It'll be done some time before the next release. I appreciate you sending a patch, but I've been busy with other things, and cosmetic changes are always going to be low priority.

@ghost
Copy link
Author

ghost commented May 14, 2020

OK, very clear.
Expected time frame for next release ?

@ElpizoZ
Copy link

ElpizoZ commented May 28, 2020

I can confirm that this issue has been fixed in 1.7.3.

@maharmstone
Copy link
Owner

@ElpizoZ, you have been told in both your previous incarnations not to spam the comments. If I ever decide that I need you to mind them for me, I'll be in touch.

@ElpizoZ
Copy link

ElpizoZ commented May 28, 2020

So, I can't let you know that an issue is no longer occurring?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants