Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNUrlPreview into functional component #32

Closed
wants to merge 4 commits into from

Conversation

ZenVega
Copy link

@ZenVega ZenVega commented Oct 8, 2020

I didn't manage to get it running yet since i never used react-native before. Nevertheless, I tried to restructure it already.

@maherzaidoune
Copy link
Owner

I didn't manage to get it running yet since i never used react-native before. Nevertheless, I tried to restructure it already.

I'll check that this week

@Hosam-hsm
Copy link

Working fine. A slight change required is to change useEffect to :

useEffect(() => {
if (props.text) {
getPreview(props.text);
} else if (props.text == null) {
setIsUri(false);
}
}, [props.text]);

@ZenVega
Copy link
Author

ZenVega commented Nov 12, 2020

Alrighty

@mir1198yusuf
Copy link

is this PR merged ?
master branch still uses class component..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants