Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Expose Scrollbar customization from RawScrollbar to Searchfield #99

Closed
LincolnJota opened this issue Oct 11, 2023 · 5 comments
Labels
easy fix should be relatively easy to fix fixed The issue is fixed in new release hacktoberfest This issue is eligible for hacktoberfest entry Proposal A detailed proposal for change to Searchfield. severe: new feature Request for a new capability or a feature

Comments

@LincolnJota
Copy link

Is your feature request related to a problem? Please describe.
I was disappointed, as a package as good as this one can't change the color of the scrollbar thumb, but it can change its visibility.
I noticed that in the code there is a RawScrollbar that has the ThumbColor property, and by default it doesn't follow the theme, its default color is a fixed color, as it says here in the official documentation: https://api.flutter.dev/flutter/widgets/RawScrollbar/thumbColor.html

Describe the solution you'd like
I'd like to move that property from the RawScrollbar widget to the SearchField widget.

@maheshmnj maheshmnj added the in triage Issue is currently being triaged label Oct 13, 2023
@maheshmnj
Copy link
Owner

Hello @LincolnJota, Thanks for filing the issue. Scrollbars definitely needs customization.

@maheshmnj maheshmnj added Proposal A detailed proposal for change to Searchfield. severe: new feature Request for a new capability or a feature and removed in triage Issue is currently being triaged labels Oct 13, 2023
@maheshmnj maheshmnj changed the title Scrollbar color [Proposal] Expose Scrollbar color from RawScrollbar to Searchfield Oct 13, 2023
@maheshmnj maheshmnj added hacktoberfest This issue is eligible for hacktoberfest entry easy fix should be relatively easy to fix labels Oct 13, 2023
@maheshmnj maheshmnj changed the title [Proposal] Expose Scrollbar color from RawScrollbar to Searchfield [Proposal] Expose Scrollbar customization from RawScrollbar to Searchfield Oct 13, 2023
maheshmnj added a commit that referenced this issue Oct 13, 2023
@maheshmnj
Copy link
Owner

Closing as fixed in #101
available in the new release v0.8.5

@maheshmnj maheshmnj added the fixed The issue is fixed in new release label Oct 13, 2023
@LincolnJota
Copy link
Author

Great, @maheshmnj ! But we still have a problem. The scroll bar shows two scroll bars, correct? I think you get the idea. To fix this scroll bar, you need to hide scrolling from the ListView, I did it here and it worked fine.

You can fix it like this:

in this line you can wrap the ListView to look like this:

child: RawScrollbar(
    // other configs....
    child: ScrollConfiguration(
      behavior: ScrollConfiguration.of(context).copyWith(scrollbars: false),
      child: listView,
    ),
),

That way, we're left with only the scroll we need. Hugs!

@maheshmnj
Copy link
Owner

Oh yes, that should be an easy fix.

@maheshmnj
Copy link
Owner

fixed in #102 available in v0.8.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy fix should be relatively easy to fix fixed The issue is fixed in new release hacktoberfest This issue is eligible for hacktoberfest entry Proposal A detailed proposal for change to Searchfield. severe: new feature Request for a new capability or a feature
Projects
None yet
Development

No branches or pull requests

2 participants