Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation data is same as testing data? #22

Open
mayurmallya opened this issue Jun 2, 2023 · 0 comments
Open

Validation data is same as testing data? #22

mayurmallya opened this issue Jun 2, 2023 · 0 comments

Comments

@mayurmallya
Copy link

Hi Richard,

Thank you for sharing the codes for Pathomic Fusion.

I went through the Mobadersany et al dataset (pnas_splits.csv) and saw that each of the splits only contains the "train" and "test" labels (no "validation" labels). So I was wondering what Pathomic fusion uses as validation data.

In the train_cv.py, within the train function (line 45), there is a call to the test function (line 88) for validating the model, which seems to be the same as the call for testing the model (line 49). So I was wondering if the data used for model validation is same as the data used for testing the model. I might be mistaken but please share your thoughts.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant