Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boltons.strutils.__all__ missing names #356

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Nov 29, 2023

Closes #355

Missed in 17c64d0, CC @mahmoud

This could've been caught by a linter (see Flake8/Ruff) or a type-checker (see mypy/pyright, #190)

@mahmoud
Copy link
Owner

mahmoud commented Nov 29, 2023

Good catch, I'll keep that in mind, thanks!

@mahmoud mahmoud merged commit 469bb26 into mahmoud:master Nov 29, 2023
9 checks passed
@Avasam Avasam deleted the patch-2 branch November 29, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names in boltons.strutils.__all__ with no definitions
2 participants