make PathAccessError.path a Path() object once more, and test as much. …

…Fixes #185.
mahmoud · Aug 11, 2020 · 0d6a45b · 0d6a45b
1 parent f85bff6
commit 0d6a45b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/glom/core.py b/glom/core.py
@@ -1458,7 +1458,7 @@ def _s_first_magic(scope, key, _t):
     try:
         cur = scope[key]
     except KeyError as e:
-        err = PathAccessError(e, _t, 0)  # always only one level depth, hence 0
+        err = PathAccessError(e, Path(_t), 0)  # always only one level depth, hence 0
     if err:
         raise err
     return cur
@@ -1499,19 +1499,19 @@ def _t_eval(target, _t, scope):
             try:
                 cur = getattr(cur, arg)
             except AttributeError as e:
-                pae = PathAccessError(e, _t, i // 2)
+                pae = PathAccessError(e, Path(_t), i // 2)
         elif op == '[':
             try:
                 cur = cur[arg]
             except (KeyError, IndexError, TypeError) as e:
-                pae = PathAccessError(e, _t, i // 2)
+                pae = PathAccessError(e, Path(_t), i // 2)
         elif op == 'P':
             # Path type stuff (fuzzy match)
             get = scope[TargetRegistry].get_handler('get', cur, path=t_path[2:i+2:2])
             try:
                 cur = get(cur, arg)
             except Exception as e:
-                pae = PathAccessError(e, _t, i // 2)
+                pae = PathAccessError(e, Path(_t), i // 2)
         elif op == '(':
             args, kwargs = arg
             scope[Path] += t_path[2:i+2:2]

diff --git a/glom/test/test_error.py b/glom/test/test_error.py
@@ -6,7 +6,7 @@
 
 import pytest
 
-from glom import glom, S, T, GlomError, Switch, Coalesce, Or
+from glom import glom, S, T, GlomError, Switch, Coalesce, Or, Path
 from glom.core import format_oneline_trace, format_target_spec_trace, bbrepr, ROOT, LAST_CHILD_SCOPE
 from glom.matching import M, MatchError, TypeMatchError, Match
 
@@ -35,6 +35,18 @@ def test_error():
         glom(target, ('data', [(T.real, T.bit_length, T.image)]))
 
 
+def test_pae_api():
+    target = {'value': {'data': [0, 1, 2]}}
+
+    with pytest.raises(GlomError) as exc_info:
+        glom(target, (T['value'], 'data.3'))
+
+    assert exc_info.value.path == Path('data', '3')
+    assert exc_info.value.path.__class__ is Path
+    assert exc_info.value.exc.__class__ is IndexError
+    assert exc_info.value.part_idx == 1
+
+
 def test_unfinalized_glomerror_repr():
     assert 'GlomError()' in repr(GlomError())