Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add curried mode to glom #30

Closed
wants to merge 1 commit into from
Closed

Conversation

jondot
Copy link

@jondot jondot commented May 25, 2018

More info: #29

@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #30 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   83.72%   83.96%   +0.23%     
==========================================
  Files           9       11       +2     
  Lines         805      817      +12     
  Branches      133      134       +1     
==========================================
+ Hits          674      686      +12     
  Misses         91       91              
  Partials       40       40
Impacted Files Coverage Δ
glom/test/test_curried.py 100% <100%> (ø)
glom/curried.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06e3d1...37b06f1. Read the comment docs.

@kurtbrose
Copy link
Collaborator

first, thanks very much for the PR!

we've had some internal discussions around something akin to re.compile() for a glom-spec which would probably cover this use case

e.g. build(spec).glom(target) or compile(spec).apply(target) -- something along those lines; having two functions named glom in the API seems confusing

also, it seems easy for users to create their own version of this if desired -- specific_glom = functools.partial(glom, spec={...})

from an internal structure perspective, 10 lines doesn't seem like enough functionality to justify its own module

@jondot
Copy link
Author

jondot commented May 29, 2018

Sure thing, feedback accepted. I’ll be watching for the complie functionality 👍🏻

@jondot jondot closed this May 29, 2018
@mahmoud mahmoud mentioned this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants