Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

working on assigning s #71

Merged
merged 4 commits into from
Dec 25, 2018
Merged

working on assigning s #71

merged 4 commits into from
Dec 25, 2018

Conversation

kurtbrose
Copy link
Collaborator

> c:\users\kurt\workspace\glom\glom\mutable.py(156)glomit()
-> if op == '[':
(Pdb) dest
ChainMap({T: {}, 'spec': Path()}, {T: {}, 'spec': (<glom.mutable.Assign object at 0x0000000002E73550>, S['foo'])}, {<class 'glom.core.Inspect'>: None, <class 'glom.core.Path'>: []}, {<function glom at 0x00000000031D1668>: <function _glom at 0x00000000031D1AC8>, <class 'glom.core.TargetRegistry'>: <glom.core.TargetRegistry object at 0x00000000031D2438>})```

not sure why scope parents seems to have that extra Path() thingie at the end

@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #71 into master will increase coverage by 0.16%.
The diff coverage is 96.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   94.69%   94.85%   +0.16%     
==========================================
  Files          14       14              
  Lines        1545     1595      +50     
  Branches      234      241       +7     
==========================================
+ Hits         1463     1513      +50     
  Misses         47       47              
  Partials       35       35
Impacted Files Coverage Δ
glom/test/test_mutable.py 98.24% <100%> (+0.03%) ⬆️
glom/mutable.py 98.88% <100%> (+0.06%) ⬆️
glom/test/test_path_and_t.py 99.07% <100%> (+0.17%) ⬆️
glom/core.py 96.86% <94.11%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946d480...d76935e. Read the comment docs.

@mahmoud
Copy link
Owner

mahmoud commented Dec 25, 2018

Added a couple more tests for more coverage, and with that I think we're ready! Merging!

@mahmoud mahmoud merged commit 3169613 into master Dec 25, 2018
@mahmoud mahmoud mentioned this pull request Dec 25, 2018
@kurtbrose
Copy link
Collaborator Author

sweet! I'm happier with how it came out than the first few stabs -- passing parent scope as the target of the glom-eval that resolves the destination feels more in the spirit of glom than messing around with scope in the body of Assign.glom

@mahmoud mahmoud deleted the s-assign branch October 28, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants