pass note callback through to actor, also test context noting (though…

… not testing actor noting yet)

lithoxyl/context.py

@@ -50,16 +50,13 @@ def note(self, name, message, *a, **kw):
         """
         if not self.note_handlers:
             return
-        # call_level = kw.pop('call_level', None)
-        callpoint = None
-        # if call_level:
-        #    callpoint = None  # TODO: extract callpoint info
-        try:
-            message = message % a
-        except Exception:
-            pass
+        if a:
+            try:
+                message = message % a
+            except Exception:
+                pass
         for nh in self.note_handlers:
-            nh(name, message, callpoint=callpoint)
+            nh(name, message)
         return
 
     def enable_async(self, **kwargs):
@@ -70,7 +67,8 @@ def enable_async(self, **kwargs):
                     'interval': kwargs.pop('interval', None),
                     'max_interval': kwargs.pop('max_interval', None),
                     # be very careful when not daemonizing thread
-                    'daemonize_thread': kwargs.pop('daemonize_thread', True)}
+                    'daemonize_thread': kwargs.pop('daemonize_thread', True),
+                    'note': self.note}
         if kwargs:
             raise TypeError('unexpected keyword arguments: %r' % kwargs.keys())
 

lithoxyl/tests/test_context.py

@@ -2,7 +2,8 @@
 
 import time
 
-from lithoxyl.context import get_context
+from lithoxyl.logger import Logger
+from lithoxyl.context import get_context, LithoxylContext
 
 
 def test_async_on_off():
@@ -19,3 +20,25 @@ def test_async_on_off():
     assert not ctx.async_actor.is_alive()
 
     return
+
+
+def test_preflush_catching_and_noting():
+    ctx = LithoxylContext()
+
+    def raiser(log):
+        raise RuntimeError('never gonna catch me')
+
+    log = Logger('test_logger', context=ctx)
+    log.preflush_hooks.append(raiser)
+
+    notes = []
+
+    def add_note(name, message):
+        notes.append((name, message))
+
+    ctx.note_handlers.append(add_note)
+
+    ctx.enable_async()
+    time.sleep(0.3)
+
+    assert notes  # should have at least one note in 300ms