Skip to content

Commit

Permalink
Resolve a FIXME
Browse files Browse the repository at this point in the history
  • Loading branch information
mahozad committed Aug 24, 2021
1 parent 721c829 commit 3b9d942
Show file tree
Hide file tree
Showing 64 changed files with 3 additions and 5 deletions.
Binary file modified piechart/src/androidTest/assets/screenshot-1.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-10.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-11.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-13.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-14.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-15.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-17.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-18.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-19.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-2.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-20.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-21.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-22.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-23.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-24.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-25.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-26.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-27.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-28.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-3.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-35.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-36.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-37.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-38.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified piechart/src/androidTest/assets/screenshot-4.png
Binary file modified piechart/src/androidTest/assets/screenshot-40.png
Binary file modified piechart/src/androidTest/assets/screenshot-41.png
Binary file modified piechart/src/androidTest/assets/screenshot-42.png
Binary file modified piechart/src/androidTest/assets/screenshot-43.png
Binary file modified piechart/src/androidTest/assets/screenshot-44.png
Binary file modified piechart/src/androidTest/assets/screenshot-45.png
Binary file modified piechart/src/androidTest/assets/screenshot-46.png
Binary file modified piechart/src/androidTest/assets/screenshot-47.png
Binary file modified piechart/src/androidTest/assets/screenshot-48.png
Binary file modified piechart/src/androidTest/assets/screenshot-49.png
Binary file modified piechart/src/androidTest/assets/screenshot-5.png
Binary file modified piechart/src/androidTest/assets/screenshot-50.png
Binary file modified piechart/src/androidTest/assets/screenshot-51.png
Binary file modified piechart/src/androidTest/assets/screenshot-52.png
Binary file modified piechart/src/androidTest/assets/screenshot-53.png
Binary file modified piechart/src/androidTest/assets/screenshot-54.png
Binary file modified piechart/src/androidTest/assets/screenshot-55.png
Binary file modified piechart/src/androidTest/assets/screenshot-56.png
Binary file modified piechart/src/androidTest/assets/screenshot-57.png
Binary file modified piechart/src/androidTest/assets/screenshot-58.png
Binary file modified piechart/src/androidTest/assets/screenshot-59.png
Binary file modified piechart/src/androidTest/assets/screenshot-6.png
Binary file modified piechart/src/androidTest/assets/screenshot-60.png
Binary file modified piechart/src/androidTest/assets/screenshot-61.png
Binary file modified piechart/src/androidTest/assets/screenshot-62.png
Binary file modified piechart/src/androidTest/assets/screenshot-63.png
Binary file modified piechart/src/androidTest/assets/screenshot-64.png
Binary file modified piechart/src/androidTest/assets/screenshot-65.png
Binary file modified piechart/src/androidTest/assets/screenshot-66.png
Binary file modified piechart/src/androidTest/assets/screenshot-67.png
Binary file modified piechart/src/androidTest/assets/screenshot-68.png
Binary file modified piechart/src/androidTest/assets/screenshot-69.png
Binary file modified piechart/src/androidTest/assets/screenshot-7.png
Binary file modified piechart/src/androidTest/assets/screenshot-70.png
Binary file modified piechart/src/androidTest/assets/screenshot-71.png
Binary file modified piechart/src/androidTest/assets/screenshot-8.png
Binary file modified piechart/src/androidTest/assets/screenshot-9.png
8 changes: 3 additions & 5 deletions piechart/src/main/kotlin/ir/mahozad/android/LegendBuilder.kt
Expand Up @@ -67,16 +67,14 @@ internal class LegendBuilder {
background = Background(legendBoxBackgroundColor),
margins = legendBoxMargins,
paddings = Paddings(legendBoxPadding),
// FIXME: If border is not enabled pass null instead of making its thickness 0.001f;
// passing null caused the whole horizontal bottom legend box to disappear.
border = Border(
if (isLegendBoxBorderEnabled) legendBoxBorder else 0.001f,
border = if (isLegendBoxBorderEnabled) Border(
thickness = legendBoxBorder,
color = legendBoxBorderColor,
alpha = legendBoxBorderAlpha,
cornerRadius = legendBoxBorderCornerRadius,
type = legendBoxBorderType,
dashArray = legendBoxBorderDashArray
)
) else null
)
return legendBox
}
Expand Down

0 comments on commit 3b9d942

Please sign in to comment.