Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unit test assertions more strict #10

Closed
mahozad opened this issue Jul 6, 2021 · 0 comments
Closed

Make unit test assertions more strict #10

mahozad opened this issue Jul 6, 2021 · 0 comments
Assignees
@mahozad
Labels
tests Related to library tests
Projects
Roadmap

Comments

@mahozad
Copy link
Owner

mahozad commented Jul 6, 2021 •
edited

In unit tests that compare floating point numbers, update the assertions to compare with 0.01 precision instead of current 1.

This is because current comparisons may give false negative results, that is, pass when they should have failed.
@mahozad mahozad added bug Something isn't working enhancement Improving an existing feature labels Jul 6, 2021
@mahozad mahozad self-assigned this Jul 6, 2021
@mahozad mahozad added this to To do in Roadmap via automation Jul 6, 2021
@mahozad mahozad added tests Related to library tests and removed bug Something isn't working enhancement Improving an existing feature labels Jul 6, 2021
@mahozad mahozad moved this from To do to In progress in Roadmap Jul 6, 2021
@mahozad mahozad closed this as completed in 733b6c6 Jul 6, 2021
mahozad added a commit that referenced this issue Jul 6, 2021
@mahozad
WIP: Make unit test assertions more strict
c57d951 
Resolves #10
mahozad added a commit that referenced this issue Jul 6, 2021
@mahozad
WIP: Make unit test assertions more strict
b526cbe 
Resolves #10
mahozad added a commit that referenced this issue Jul 6, 2021
@mahozad
WIP: Make unit test assertions more strict
b7f9e15 
Resolves #10
mahozad added a commit that referenced this issue Jul 8, 2021
@mahozad
WIP: Make unit test assertions more strict
16ed66e 
Resolves #10
mahozad added a commit that referenced this issue Jul 8, 2021
@mahozad
WIP: Make unit test assertions more strict
556c70f 
Resolves #10
mahozad added a commit that referenced this issue Jul 8, 2021
@mahozad
WIP: Make unit test assertions more strict
c4692b7 
Resolves #10
mahozad added a commit that referenced this issue Jul 8, 2021
@mahozad
WIP: Make unit test assertions more strict
e7a927b 
Resolves #10
mahozad added a commit that referenced this issue Jul 8, 2021
@mahozad
Make unit test assertions more strict
5a292d6 
Resolves #10
@mahozad mahozad moved this from In progress to Done in Roadmap Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahozad mahozad

Labels
tests Related to library tests
Projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mahozad