Add asset channel as way to export assets #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…channel and preserve them from being not displayed in the final transcript (as long as the asset channel doesn't get deleted)
mahtoid
reviewed
Aug 19, 2023
mahtoid
reviewed
Aug 19, 2023
mahtoid
reviewed
Aug 19, 2023
mahtoid
reviewed
Aug 19, 2023
|
Would you like to update the README as well to include this new optional argument? |
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Signed-off-by: doluk <69309597+doluk@users.noreply.github.com>
Added it |
mahtoid
reviewed
Aug 20, 2023
mahtoid
added a commit
that referenced
this pull request
Apr 1, 2024
* Add asset channel as way to export assets (#91) * Addition of an optional asset channel to save attachments to another channel and preserve them from being not displayed in the final transcript (as long as the asset channel doesn't get deleted) * Fetch attachments properly as Bytes and send them into the attachment channel * propagate errors from sending assets to asset channel to user level * Cleanup code after 1st review Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Add new attribute to README.md Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * cleanup Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Fix missing keyword argument --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Implement member caching across multiple instances of MemberConstruct (#92) * feat: implement caching members in MessageConstructs * version bump * Asset Handler (#96) - Removal of asset_channel feature - Addition of AssetHandler origin class - Addition of two examples for implementing AssetHandlers in form of LocalFileHostHandler and DiscordChannelHandler (latter one has the same functionality as the asset_channel) - Bugfix: Preventing code blocks from being parsed for other markdown - Bugfix: Fix timestamp markdown - Bugfix: Fix div tags for pinned messages - Bugfix: Fix parsing and css of here and everyone mentions - Bugfix: Attempting to create a transcript of an empty channel would lead to an IndexError - Bugfix: Fixing erroring in some channels but not others #98 - Addition of list markdown - Addition of heading markdown * README update * Explain the concept of AttachmentHandlers (#99) * Explain the AttachmentHandler concept Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> * Deduplicate Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> --------- Signed-off-by: doluk <69309597+doluk@users.noreply.github.com> Co-authored-by: Lukas Dobler <69309597+doluk@users.noreply.github.com> Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com> Co-authored-by: mahtoid <git@mahto.id>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing a channel to the export function, the assets get exported to this channel. Meaning deleting the channel of the transcript does not lead to missing assets in the transcripts/dead links.