Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark color-section as unimportant in delta mode #769

Closed
alschmut opened this issue Nov 1, 2019 · 3 comments · Fixed by #2317
Closed

Mark color-section as unimportant in delta mode #769

alschmut opened this issue Nov 1, 2019 · 3 comments · Fixed by #2317
Assignees
@Shivan-997
Labels
feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@alschmut
Copy link
Contributor

alschmut commented Nov 1, 2019 •
edited

Feature request

Description

This issue originated from an 696 issue comment

In delta mode the chosen color-metric has no impact at all, as the map is coloured according to the difference of the height metric. So maybe we should show the color-metric section differently when delta is activated, ex. following options

  • remove the section
  • darken the section in light grey
  • disable the metric-chooser select
  • not show hovered-values for the color-metric

... or a combination of multiple options
@alschmut alschmut added the pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. label Nov 1, 2019
@alschmut
Copy link
Contributor Author

alschmut commented Nov 1, 2019

In my opinion, I would do at least the following:

  • disable the metric-chooser select and
  • not show hovered-values for the color-metric

@alschmut alschmut mentioned this issue Nov 3, 2019
Closed
@BridgeAR BridgeAR added feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:high Set by PO blocked The issue or feature is blocked on another issue or PR that has to be resolved first labels Dec 27, 2020
@BridgeAR
Copy link
Member

We should figure out how deactivating the the color metric plays nicely with choosing different colors. @Gaugi28 do you have any thoughts on this?

@Gaugi28
Copy link

Gaugi28 commented Jan 8, 2021

After discussion with @BridgeAR:

Feature request

Description

As a user, I want color settings in the delta mode, so I can change the color. Further I don't want to see metrics which I cannot change in the delta mode like the color and edge metrics.

Acceptance criteria

  • In the delta mode the color and edge metric input fields are removed.
  • Instead of the color metric there is a dropdown where the user can set the colors (see image).
  • The dropdown has the label "Color Settings".
  • The user can pick the color as described here.

ColorSettingsDeltaMode
image

@shaman-apprentice shaman-apprentice removed their assignment Jan 22, 2021
@BridgeAR BridgeAR removed the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Jul 21, 2021
@Shivan-997 Shivan-997 self-assigned this Jul 26, 2021
@Shivan-997 Shivan-997 mentioned this issue Jul 26, 2021
Merged
Shivan-997 pushed a commit that referenced this issue Jul 26, 2021
add changes to changelog #769
62fdb67
Shivan-997 pushed a commit that referenced this issue Jul 27, 2021
add new test to ribbonbar #769
a1570a7
RomanenkoVladimir added a commit that referenced this issue Jul 30, 2021
@Shivan-997 @RomanenkoVladimir
Mark color-section as unimportant in delta mode (#2317)
6b9a5a6 
* remove color and edge metric card for delta mode. add color settings card

* add changes to changelog #769

* add new test to ribbonbar #769

Co-authored-by: Shivan Oskan <shivan.oskan@maibornwolff.de>
Co-authored-by: RomanenkoVladimir <volodymyr.romanenko@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shivan-997 Shivan-997

Labels
feature Feature requests javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark color-section as unimportant in delta mode MaibornWolff/codecharta
5 participants
@shaman-apprentice @BridgeAR @Gaugi28 @alschmut @Shivan-997