Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

We add all connections to the bootstrap list #91

Closed
Fraser999 opened this issue May 6, 2015 · 4 comments
Closed

We add all connections to the bootstrap list #91

Fraser999 opened this issue May 6, 2015 · 4 comments
Assignees

Comments

@Fraser999
Copy link
Contributor

It looks like we unconditionally add peer TCP endpoints to the bootstrap list, even though the remote end may not be a TCP listening endpoint and will be unable to accept new connections.

@dirvine
Copy link
Contributor

dirvine commented May 6, 2015

Ah that's not good.

@Viv-Rajkumar
Copy link
Contributor

that might explain #85 to some extent?

@Fraser999 Fraser999 changed the title We add all connection to the bootstrap list We add all connections to the bootstrap list May 8, 2015
@dirvine dirvine added the ready label Jun 14, 2015
@chandraprakash chandraprakash removed their assignment Jun 17, 2015
@vinipsmaker
Copy link
Contributor

Now we have a custom Crust handshake and we already have some "filters" to bootstrap list (given the issue description) for some time. Can I mark the issue as closed?

@Fraser999
Copy link
Contributor Author

If the filtering means we're now only adding contacts who we'd be able to bootstrap off (assuming their endpoints don't change), then yes, please close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants