-
Notifications
You must be signed in to change notification settings - Fork 126
add handshake to connection establishment #330
Conversation
r? @inetic (maidsafe_highfive has picked a reviewer for you, use r? to override) |
|
|
6d721a6
to
a27964c
Compare
hey @inetic, PR is ready for review (just waiting for CI tests). |
All tests are passing and I'm seeing a green light from the CI machines. |
/// | ||
/// Only after the handshake is exchanged, crust should generate new | ||
/// connection events. | ||
Handshake, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Handshake
should not be part of the Message
enum as we'll never send UserBlob
nor Contacts
while handshaking and we'll never send Handshake
while receiving UserBlob
or Contacts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved. Just waiting for the CI tests.
Solves https://maidsafe.atlassian.net/browse/MAID-1353 Currently an "empty" message is sent as the handshake, but the plan is to change the message to exchange public endpoints which will help with hole punching.
a27964c
to
d80c8a6
Compare
add handshake to connection establishment
Changes Unknown when pulling d80c8a6 on vinipsmaker:MAID-1353 into ** on maidsafe:master**. |
Solves https://maidsafe.atlassian.net/browse/MAID-1353
Currently an "empty" message is sent as the handshake, but the plan is
to change the message to exchange public endpoints which will help with
hole punching.