This repository has been archived by the owner on Jan 7, 2020. It is now read-only.
MAID-2688 fix/error: adds missing error handling for failed app_reconnect #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterlester
commented
Jun 20, 2018
| @@ -53,22 +53,6 @@ const readFileInfo = (fileInfo) => { | |||
| ? new Buffer(0) | |||
| : new Buffer(ref.reinterpret(file.user_metadata_ptr, file.user_metadata_len)); | |||
|
|
|||
| if (user_metadata_ptr) { | |||
There was a problem hiding this comment.
Why remove this branch?
The addition of error handling at https://github.com/maidsafe/safe_app_nodejs/pull/252/files#diff-c2284895deccc698165325b396ad79b9R93, creates a decrease in code coverage however I'm not able to create a testing condition where app_reconnect throws an error in mock routing.
Thus my search for a way to increase coverage to make coveralls happy.
The above block of code is safe to remove because the condition can never be met since user_metadata_ptr will always be an instance of Buffer.
cc: @bochaco
bochaco
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.