chore/ci: initial setup #20
Conversation
.gitignore
Outdated
| target | ||
| Cargo.lock | ||
| .direnv.* | ||
| Skip to content |
There was a problem hiding this comment.
Looks like the first 18 and last 13 lines of this have been accidentally copied in?
| "Carl Lerche <me@carllerche.com>", | ||
| "Andrew Cann <shum@canndrew.org>", | ||
| ] | ||
| authors = ["MaidSafe Developers <dev@maidsafe.net>"] | ||
| description = "tokio-based uTP implementation" | ||
| documentation = "https://docs.rs/tokio-utp" |
There was a problem hiding this comment.
I think this documentation = link may break once this crate renaming goes through.
There was a problem hiding this comment.
Changed name = back to tokio-utp so that should resolve this issue (no crate renaming will occur)
| @@ -5,11 +5,13 @@ An implementation of [UTP] for Rust using non-blocking sockets. | |||
|
|
|||
| |Crate|Documentation|Linux/OS X|Windows|Issues| | |||
| |:---:|:-----------:|:--------:|:-----:|:----:| | |||
| |[](https://crates.io/crates/tokio-utp)|[](https://docs.rs/tokio-utp)|[](https://travis-ci.org/maidsafe/tokio-utp)|[](https://ci.appveyor.com/project/MaidSafe-QA/tokio-utp/branch/master)|[](https://waffle.io/maidsafe/tokio-utp)| | |||
| |[](https://crates.io/crates/tokio-utp)|[](https://docs.rs/tokio-utp)|[](https://travis-ci.org/maidsafe/tokio_utp)|[](https://ci.appveyor.com/project/MaidSafe-QA/tokio-utp/branch/master)|[](https://waffle.io/maidsafe/tokio_utp)| | |||
There was a problem hiding this comment.
I think the crates.io links may remain valid after the renaming, but not so sure about the others. To be safe (and consistent with our other projects), it'd be better to change all instances of tokio-utp to tokio_utp except the AppVeyor link.
There was a problem hiding this comment.
Changed name = back to tokio-utp so that should resolve this issue (no crate renaming will occur). Means inconsistency within this file as crate, docs and Appveyor links will still be tokio-utp, while the rest will be tokio_utp.
README.md
Outdated
| Licensed under the ([MIT](LICENSE)) license. | ||
| Licensed under: | ||
| * the Modified BSD ([LICENSE-BSD](https://opensource.org/licenses/BSD-3-Clause)) or | ||
| * the MIT license ([LICENSE-MIT](http://opensource.org/licenses/MIT)) |
Cargo.toml
Outdated
| license = "MIT/Apache-2.0" | ||
| name = "tokio-utp" | ||
| repository = "https://github.com/canndrew/tokio-utp" | ||
| license = "MIT/BSD" |
There was a problem hiding this comment.
This line should be
license = "MIT OR BSD-3-Clause"
There was a problem hiding this comment.
so basically pls use whatever is there in safe_app @StephenCoyleAtMaidSafe , to be consistent
| @@ -1,3 +1,232 @@ | |||
| target | |||
There was a problem hiding this comment.
pls use safe_client_libs's .gitignore
Cargo.toml
Outdated
| license = "MIT/Apache-2.0" | ||
| name = "tokio-utp" | ||
| repository = "https://github.com/canndrew/tokio-utp" | ||
| license = "MIT/BSD" |
There was a problem hiding this comment.
so basically pls use whatever is there in safe_app @StephenCoyleAtMaidSafe , to be consistent
Cargo.toml
Outdated
| name = "tokio-utp" | ||
| repository = "https://github.com/canndrew/tokio-utp" | ||
| license = "MIT/BSD" | ||
| name = "tokio_utp" |
There was a problem hiding this comment.
also let's call this tokio-utp in line with all the tokio prefixed crates in crates.io. Here's a list from @povilasb for reference: https://docs.rs/releases/search?query=tokio
Our repo is still tokio_utp which is fine and in line with our convention
Updated/Created: