Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add peer address to connection log messages #247

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

iancoleman
Copy link
Contributor

No description provided.

@iancoleman iancoleman requested a review from a team as a code owner March 28, 2021 23:13
@iancoleman
Copy link
Contributor Author

Clippy failures are unrelated to the changes in this PR, should I fix them here or not?

error: name `TLS` contains a capitalized acronym
  --> src/error.rs:65:5
   |
65 |     TLS(#[from] rustls::TLSError),
   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Tls`
   |

@dirvine
Copy link
Member

dirvine commented Mar 28, 2021

Clippy failures are unrelated to the changes in this PR, should I fix them here or not?

error: name `TLS` contains a capitalized acronym
  --> src/error.rs:65:5
   |
65 |     TLS(#[from] rustls::TLSError),
   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Tls`

You are OK here Ian as this is not our issue, rustls needs to solve this.

@dirvine dirvine merged commit 1130207 into maidsafe:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants