chore: rotate logs after exceeding 20mb

The previous rotation strategy was using the number of lines, which was set to 5000.

Users recently noticed this limitation was producing lots of logs, so we've changed the strategy to
be based on the size of the log in bytes.

sn_logging/src/appender.rs

@@ -33,7 +33,7 @@ use tracing_appender::non_blocking::{NonBlocking, WorkerGuard};
 /// - older files are deleted.
 pub(super) fn file_rotater(
     dir: &PathBuf,
-    max_lines: usize,
+    max_bytes: usize,
     uncompressed_files: usize,
     max_files: usize,
 ) -> (NonBlocking, WorkerGuard) {
@@ -50,7 +50,7 @@ pub(super) fn file_rotater(
         dir,
         format!("{binary_name}.log"),
         AppendTimestamp::default(FileLimit::MaxFiles(max_files)),
-        ContentLimit::Lines(max_lines),
+        ContentLimit::BytesSurpassed(max_bytes),
         Compression::OnRotate(uncompressed_files),
     );
 

sn_logging/src/lib.rs

@@ -30,6 +30,10 @@ use tracing_subscriber::{
     Layer, Registry,
 };
 
+const MAX_LOG_SIZE: usize = 20 * 1024 * 1024;
+const MAX_UNCOMPRESSED_LOG_FILES: usize = 100;
+const MAX_LOG_FILES: usize = 1000;
+
 #[derive(Debug, Clone)]
 pub enum LogOutputDest {
     Stdout,
@@ -123,12 +127,12 @@ impl TracingLayers {
                 std::fs::create_dir_all(path)?;
                 println!("Logging to directory: {path:?}");
 
-                let logs_max_lines = 5000;
-                let logs_uncompressed = 100;
-                let logs_max_files = 1000;
-
-                let (file_rotation, worker_guard) =
-                    appender::file_rotater(path, logs_max_lines, logs_uncompressed, logs_max_files);
+                let (file_rotation, worker_guard) = appender::file_rotater(
+                    path,
+                    MAX_LOG_SIZE,
+                    MAX_UNCOMPRESSED_LOG_FILES,
+                    MAX_LOG_FILES,
+                );
                 self.guard = Some(worker_guard);
 
                 match format {