refactor(cli): remove unpaid/paid distinction from chunk manager #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandSherwin
commented
Nov 29, 2023
| } | ||
| } | ||
| } | ||
| progress_bar.finish_and_clear(); | ||
|
|
||
| // report errors | ||
| let failed_payments = chunk_manager.get_unpaid_chunks(); |
There was a problem hiding this comment.
I think this would not have worked prior to the changes too as we call mark_paid and mark_verfied right after each other.
I don't think we have any way to just know if the payment alone failed?
There was a problem hiding this comment.
Indeed! Although we might want to keep printing out pay errors.
There was a problem hiding this comment.
By checking recorded_pay_errors.len() instead
There was a problem hiding this comment.
Ah I see! Updated the PR.
RolandSherwin
force-pushed
the
chunk_manager_remove_verification
branch
from
675dd86
to
a9fac3d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RolandSherwin
force-pushed
the
chunk_manager_remove_verification
branch
from
a9fac3d
to
cd7c535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997
Description
Summary generated by Reviewpad on 29 Nov 23 18:13 UTC
This pull request includes changes related to the upload of file chunks.
unpaid_chunks_to_uploadandunpaid_chunks_to_upload_lenhave been renamed tochunks_to_uploadandchunks_to_upload_len, respectively.chunks_to_upload_leninstead ofunpaid_chunks_to_upload_len.mark_paidandmark_verifiedhave been replaced withmark_completed.failed_payments,failed_uploads,failed_payments_len, andtotal_failureshave been removed.{chunks_to_upload_len}.These changes improve the upload process and provide better logging information.